Skip to content

#34640: CLN: remove 'private_key' and 'verbose' from gbq #34654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 24, 2020
Merged

#34640: CLN: remove 'private_key' and 'verbose' from gbq #34654

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9083e5d
#34640: CLN: remove 'private_key' and 'verbose' from gbq
parkdj1 Jun 8, 2020
d60a360
close GH 34640 (updated)
parkdj1 Jun 15, 2020
07293e6
close GH 34640 (update doc)
parkdj1 Jun 17, 2020
8b8427a
close GH 34640 (update doc)
parkdj1 Jun 17, 2020
287c5c5
Merge branch 'master' into master
parkdj1 Jun 17, 2020
182d453
close GH 34640 edits
parkdj1 Jun 25, 2020
215a719
close GH 34640 edits
parkdj1 Jun 25, 2020
586528c
Merge branch 'master' into master
parkdj1 Jun 27, 2020
522e9cc
Update parsers.py
parkdj1 Jun 29, 2020
aadbf12
Merge remote-tracking branch 'upstream/master' into parkdj1-master
WillAyd Sep 1, 2020
7a7351a
fixed whatsnew note
WillAyd Sep 1, 2020
72c5f48
fixed merge
WillAyd Sep 1, 2020
a7a4043
extra space
WillAyd Sep 1, 2020
5810047
reverted parser changes
WillAyd Sep 1, 2020
0d79065
Merge remote-tracking branch 'upstream/master' into parkdj1-master
WillAyd Sep 10, 2020
7c0bf57
func fixup
WillAyd Sep 10, 2020
9189cfd
Merge remote-tracking branch 'upstream/master' into parkdj1-master
WillAyd Sep 11, 2020
4cadb0f
removed space
WillAyd Sep 11, 2020
4e441e4
Merge remote-tracking branch 'upstream/master' into parkdj1-master
WillAyd Sep 21, 2020
a09851f
whatsnew updates
WillAyd Sep 21, 2020
3067b97
Merge remote-tracking branch 'upstream/master' into parkdj1-master
WillAyd Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/source/whatsnew/v1.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ ExtensionArray

Other
^^^^^

- Removed ``private_key`` and ``verbose`` from :func:`read_gbq` (:issue:`34654` :issue:`30200`)
- Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` incorrectly raising ``AssertionError`` instead of ``ValueError`` when invalid parameter combinations are passed (:issue:`36045`)
- Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` with numeric values and string ``to_replace`` (:issue:`34789`)
-
Expand Down
6 changes: 0 additions & 6 deletions pandas/io/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ def read_gbq(
credentials=None,
use_bqstorage_api: Optional[bool] = None,
max_results: Optional[int] = None,
private_key=None,
verbose=None,
progress_bar_type: Optional[str] = None,
) -> "DataFrame":
"""
Expand Down Expand Up @@ -208,8 +206,6 @@ def to_gbq(
location: Optional[str] = None,
progress_bar: bool = True,
credentials=None,
verbose=None,
private_key=None,
) -> None:
pandas_gbq = _try_import()
pandas_gbq.to_gbq(
Expand All @@ -224,6 +220,4 @@ def to_gbq(
location=location,
progress_bar=progress_bar,
credentials=credentials,
verbose=verbose,
private_key=private_key,
)