feat(op, txpool): add additional update routine for conditionals #14497
+106
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 14, 2025
| let Some(event) = events.next().await else { break }; | ||
| if let CanonStateNotification::Commit { new } = event { | ||
| if !new.is_empty() { | ||
| let header = new.tip().clone().into_header(); |
There was a problem hiding this comment.
I blieve there should be clone_header
| if !new.is_empty() { | ||
| let header = new.tip().clone().into_header(); | ||
| let mut to_remove = Vec::new(); | ||
| for tx in &pool.pooled_transactions() { |
There was a problem hiding this comment.
I think this should be fine, even with a low blocktime to run every 1-2s
@hai-rise is support for 4337 conditionals even relevant for you? if not you can just not spawn this task
| } | ||
| } | ||
| } | ||
| let _ = pool.remove_transactions(to_remove); |
There was a problem hiding this comment.
I think we also want some metrics for this
crates/optimism/node/src/node.rs
Outdated
Comment on lines
517
to
524
| let chain_events = ctx.provider().canonical_state_stream(); | ||
| ctx.task_executor().spawn_critical( | ||
| "Op txpool maintenance task", | ||
| reth_optimism_txpool::maintain::maintain_transaction_pool_future( | ||
| pool, | ||
| chain_events, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
ideally this also has access to the enable conditional setting so we can spawn this based on that, I believe we can pass this setting down
mattsse
approved these changes
Feb 15, 2025
Comment on lines
+111
to
+112
| OpPoolBuilder::default() | ||
| .with_enable_tx_conditional(self.args.enable_tx_conditional), |
There was a problem hiding this comment.
great that we can already propagate additional cli settings like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14196