Skip to content

Conversation

@rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Jan 10, 2026

Description

  • Rework remote externality child key test; it was failing since the proxy pallet has no child storages
  • Test WS client initialization in remote externality Transport layer builder; connects to remote-externalities: Use WsClient #10258 .

Integration

N/A

Review Notes

N/A

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: Use /cmd label <label-name> to add labels
    • Maintainers can also add labels manually
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

bkchr and others added 8 commits November 8, 2025 17:57
@rockbmb rockbmb self-assigned this Jan 10, 2026
@rockbmb rockbmb added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 10, 2026
@rockbmb rockbmb changed the title Remote externalities wsclient Extend remote externalities Transport + child storage query unit tests Jan 10, 2026
@rockbmb rockbmb marked this pull request as ready for review January 12, 2026 15:09
@rockbmb rockbmb added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jan 12, 2026
@bkchr
Copy link
Member

bkchr commented Jan 12, 2026

This is probably superseded by: #10779

rockbmb added a commit to paritytech/try-runtime-cli that referenced this pull request Jan 13, 2026
Live mode works with either ws(s):// or http(s):// in --uri. The endpoint
is converted to HTTP for state download and to WS for block/header RPC.

This is a temporary workaround until frame-remote-externalities restores
proper WS transport support in a future release; see
paritytech/polkadot-sdk#10258,
paritytech/polkadot-sdk#10766, and
paritytech/polkadot-sdk#10779 .
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21215704782
Failed job name: fmt

@rockbmb
Copy link
Contributor Author

rockbmb commented Jan 21, 2026

Closed in favor of #10866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants