-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Extend remote externalities Transport + child storage query unit tests
#10766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+86
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was removing the rewrite of the uri from `ws(s)` to `http(s)`, but I forgot to change `HttpClient` to `WsClient`. This is now done by this pr.
It is not possible at this time to support building a remote externality over WebSockets (WsClient type incompatible with Transport enum).
Transport + child storage query unit tests
Member
|
This is probably superseded by: #10779 |
rockbmb
added a commit
to paritytech/try-runtime-cli
that referenced
this pull request
Jan 13, 2026
Live mode works with either ws(s):// or http(s):// in --uri. The endpoint is converted to HTTP for state download and to WS for block/header RPC. This is a temporary workaround until frame-remote-externalities restores proper WS transport support in a future release; see paritytech/polkadot-sdk#10258, paritytech/polkadot-sdk#10766, and paritytech/polkadot-sdk#10779 .
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
4 tasks
Contributor
Author
|
Closed in favor of #10866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
R0-no-crate-publish-required
The change does not require any crates to be re-published.
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transportlayer builder; connects to remote-externalities: UseWsClient#10258 .Integration
N/A
Review Notes
N/A
Checklist
Trequired)/cmd label <label-name>to add labels