Skip to content

Fix test for remote externality's selective child key retrieval mechanism #10866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rockbmb wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix test for remote externality's selective child key retrieval mechanism #10866

rockbmb wants to merge 10 commits into from
+140 −11

Conversation

@rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Jan 21, 2026 •
edited
Loading

Description

Follow-up to #10766, which was closed in favor of #10779.
Rework remote externality child key test; it was failing since the proxy pallet has no child storages.

Integration

N/A

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: Use /cmd label <label-name> to add labels
    • Maintainers can also add labels manually
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@rockbmb
Rename default endpoint var used in tests
7e939b9 
Also, have it use a WS and not HTTP URI, as remote externalities
require the former and fail with the latter.
@rockbmb
Fix child_keys_are_loaded test
5119b3c 
It was failing since the proxy pallet has no child storages with which
to test the selective child key loading mechanism of remote externality
retrieval.
@rockbmb rockbmb self-assigned this Jan 21, 2026
@rockbmb rockbmb added T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests. labels Jan 21, 2026
@rockbmb rockbmb mentioned this pull request Jan 21, 2026
Closed
4 tasks
@rockbmb rockbmb requested a review from bkchr January 21, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@rockbmb rockbmb

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rockbmb @bkchr