FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032

lprimak · 2024-10-18T04:56:57Z

Description

Bugfix. BeanManager isn't properly constructed when multiple CDI WARs exist in an EAR.
Also allows EAR-libraries to be scanned for CDI annotations

fixes #7031
also fixes #7078
Appears specifically when multiple WARs use OmniFaces

Important Info

This is the head PR in the CDI-performance and modernization sequence.
PRs #7165 and #7097 depend on this PR

Testing

Tested with the failing reproducer
** Needs TCK run

lprimak · 2024-10-28T06:11:42Z

@Pandrex247 Do you think you can run the TCK against this PR?
I'd like to make sure I didn't break anything.

Thank you!

Pandrex247 · 2024-10-28T16:37:16Z

@lprimak I ran it through the CDI and EJB TCKs and all seems green 👍

lprimak · 2024-10-28T16:39:01Z

Thanks, Fantastic!
I gotta do a lot more testing on my end, but this is promising!

appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java

lprimak · 2024-11-10T09:07:34Z

I have found a few issues that I found with "real" applications.
I think I worked through most of them, so stay tuned

lprimak · 2024-11-10T09:08:51Z

~~I may also roll a fix for #6405 if that's trivial as well~~

lprimak · 2024-11-21T06:20:35Z

Im getting close. "Real" application runs.

lprimak · 2024-11-26T20:17:42Z

Ready to go. Will do #6405 in a separate PR

lprimak · 2024-11-27T18:41:43Z

Now I gotta fix the conflict :)

lprimak · 2024-11-27T22:21:53Z

Once the tests passes I am going to squash the commits and un-draft the PR again

lprimak · 2024-11-28T00:11:43Z

Ready to go again

appserver/web/war-util/pom.xml

lprimak · 2025-01-20T19:13:01Z

This one is the head of the backlog now

luiseufrasio · 2025-01-31T13:20:26Z

jenkins test please

luiseufrasio · 2025-01-31T13:55:18Z

@lprimak I tried to run jenkins test again after your last update and it is not working

lprimak · 2025-01-31T17:29:56Z

The conflicts arose due to merging of #7163
~~I believe~~ that's fixed now

luiseufrasio

@lprimak I had 2 issues:

I could not build the reproducer on Windows 11, only on WSL (Ubuntu 22.04):
The deploy of ear1-1.x-SNAPSHOT.ear built in WSL works when running Payara Server on Windows 11 and on WSL, but when I launch the war applications it only works on WSL. On Windows 11 I had HTTP 500 error:

lprimak · 2025-02-04T15:48:56Z

I don't have windows so I really can't do anything about that. Not sure what the issue even may be

lprimak · 2025-02-04T19:26:04Z

Reproducer builds fine on Windows, as it looks like, but it won't run.
Use -Ppayara-server-local to skip payara startup.

As far as 500 error, I have no idea as I don't have windows. Do you have an exception at least?
I may need your help reproducing this if it's not trivial.

luiseufrasio · 2025-02-04T21:10:55Z

These are the log server, but it is not related to your application:

[#|2025-02-04T18:02:18.266-0300|INFO|Payara 6.2025.2|javax.enterprise.system.core|_ThreadID=245;_ThreadName=admin-thread-pool::admin-listener(2);_TimeMillis=1738702938266;_LevelValue=800;|
  ear1-1.x-SNAPSHOT was successfully deployed in 8,775 milliseconds.|#]

[#|2025-02-04T18:02:18.564-0300|SEVERE|Payara 6.2025.2|org.glassfish.admingui.common.util.JerseyRestResponse|_ThreadID=245;_ThreadName=admin-thread-pool::admin-listener(2);_TimeMillis=1738702938564;_LevelValue=1000;|
  Unsupported Response Format: 'text/html;charset=iso-8859-1'!|#]

[#|2025-02-04T18:02:18.565-0300|SEVERE|Payara 6.2025.2|org.glassfish.admingui|_ThreadID=245;_ThreadName=admin-thread-pool::admin-listener(2);_TimeMillis=1738702938565;_LevelValue=1000;|
  RestResponse.getResponse() gives FAILURE.  endpoint = 'http://local:4848/management/domain/nodes/node/localhost-domain1'; attrs = '{}'|#]

[#|2025-02-04T18:02:18.565-0300|INFO|Payara 6.2025.2|org.glassfish.admingui|_ThreadID=245;_ThreadName=admin-thread-pool::admin-listener(2);_TimeMillis=1738702938565;_LevelValue=800;|
  Exception Occurred :java.lang.RuntimeException: java.lang.RuntimeException: |#]

But a different error occurs when trying to undeploy:

[#|2025-02-04T18:09:26.413-0300|WARNING|Payara 6.2025.2|javax.enterprise.system.util|_ThreadID=299;_ThreadName=admin-thread-pool::admin-listener(4);_TimeMillis=1738703366413;_LevelValue=900;|
  ASURLClassLoader EarLibClassLoader :
doneCalled = true
doneSnapshot = ASURLClassLoader.done() called ON EarLibClassLoader :
urlSet = []
doneCalled = false
 Parent -> org.glassfish.internal.api.DelegatingClassLoader@57bf6309

 AT Tue Feb 04 18:09:26 GFT 2025
 BY :[java.base/java.lang.Thread.getStackTrace(Thread.java:2450), com.sun.enterprise.loader.ASURLClassLoader.done(ASURLClassLoader.java:205), com.sun.enterprise.loader.ASURLClassLoader.preDestroy(ASURLClassLoader.java:171), org
.glassfish.javaee.full.deployment.EarClassLoader.preDestroy(EarClassLoader.java:122), org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(ServiceLocatorImpl.java:1068), org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(Serv
iceLocatorImpl.java:1052), org.glassfish.internal.data.ApplicationInfo.clean(ApplicationInfo.java:490), com.sun.enterprise.v3.server.ApplicationLifecycle.unload(ApplicationLifecycle.java:1400), com.sun.enterprise.v3.server.Appl
icationLifecycle.undeploy(ApplicationLifecycle.java:1428), org.glassfish.deployment.admin.UndeployCommand.execute(UndeployCommand.java:431), com.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:556), com
.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:552), java.base/java.security.AccessController.doPrivileged(AccessController.java:400), java.base/javax.security.auth.Subject.doAs(Subject.java:453), com
.sun.enterprise.v3.admin.CommandRunnerImpl$2.execute(CommandRunnerImpl.java:551), com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunnerImpl.java:582), com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunne
rImpl.java:574), java.base/java.security.AccessController.doPrivileged(AccessController.java:400), java.base/javax.security.auth.Subject.doAs(Subject.java:453), com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRun
nerImpl.java:573), com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:1497), com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1879), com.sun.enterprise.v3
.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1755), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:272), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.
java:240), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:294), org.glassfish.admin.rest.resources.TemplateRestResource.runCommand(TemplateRestResource.java:570), org.glassfish.admin.rest.resources.Tem
plateRestResource.doDelete(TemplateRestResource.java:307), org.glassfish.admin.rest.resources.TemplateRestResource.delete(TemplateRestResource.java:190), java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMe
thodHandleAccessor.java:103), java.base/java.lang.reflect.Method.invoke(Method.java:580), org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.
java:52), org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:146), org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.inv
oke(AbstractJavaResourceMethodDispatcher.java:189), org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176), org.glassfish.jer
sey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:93), org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:478), org.glassfis
h.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:400), org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:81), org.glassfish.jersey.server.ServerRuntime$1.run(Se
rverRuntime.java:274), org.glassfish.jersey.internal.Errors$1.call(Errors.java:248), org.glassfish.jersey.internal.Errors$1.call(Errors.java:244), org.glassfish.jersey.internal.Errors.process(Errors.java:292), org.glassfish.jer
sey.internal.Errors.process(Errors.java:274), org.glassfish.jersey.internal.Errors.process(Errors.java:244), org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266), org.glassfish.jersey.server.Serv
erRuntime.process(ServerRuntime.java:253), org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:696), org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:367)
, org.glassfish.admin.rest.adapter.RestAdapter$2.service(RestAdapter.java:335), org.glassfish.admin.rest.adapter.RestAdapter.service(RestAdapter.java:189), org.glassfish.admin.rest.adapter.RestManagementAdapter.service(RestMana
gementAdapter.java:66), com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:520), com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:217), org.glassfis
h.grizzly.http.server.HttpHandler.runService(HttpHandler.java:174), org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:153), org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.ja
va:202), org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:88), org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:246), org.glassfish.grizzly.filterchain
.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:178), org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:118), org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultF
ilterChain.java:96), org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:51), org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:510), org.glassfish.grizzly.strategies.Abstra
ctIOStrategy.fireIOEvent(AbstractIOStrategy.java:82), org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:83), org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.ru
n(WorkerThreadIOStrategy.java:101), org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:535), org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:515), java.base/java.lang.Thread.run(Thread.java:1583)] Parent -> org.glassfish.internal.api.DelegatingClassLoader@57bf6309
 was requested to find class org.omnifaces.cdi.eager.EagerBeansRepository after done was invoked from the following stack trace
java.lang.Throwable
        at com.sun.enterprise.loader.ASURLClassLoader.findClassData(ASURLClassLoader.java:791)
        at com.sun.enterprise.loader.ASURLClassLoader.findClass(ASURLClassLoader.java:704)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)

lprimak · 2025-02-04T21:15:53Z

Yes, that doesn't look at all related.

luiseufrasio · 2025-02-06T12:51:52Z

Yes, that doesn't look at all related.

@lprimak forget about the 1st issue regarding Windows 11, It was my local maven repo which was corrupted.

Now please try to reproduce the Undeploy issue on your local, because this one seems to be related to your changes:

As you can see in the image above it is very slow and into the logs we have:

[#|2025-02-06T09:47:21.455-0300|WARNING|Payara 6.2025.2|javax.enterprise.system.util|_ThreadID=302;_ThreadName=admin-thread-pool::admin-listener(3);_TimeMillis=1738846041455;_LevelValue=900;|
  ASURLClassLoader EarLibClassLoader :
doneCalled = true
doneSnapshot = ASURLClassLoader.done() called ON EarLibClassLoader :
urlSet = []
doneCalled = false
 Parent -> org.glassfish.internal.api.DelegatingClassLoader@2437c706

 AT Thu Feb 06 09:47:21 GFT 2025
 BY :[java.base/java.lang.Thread.getStackTrace(Thread.java:2450), com.sun.enterprise.loader.ASURLClassLoader.done(ASURLClassLoader.java:205), com.sun.enterprise.loader.ASURLClassLoader.preDestroy(ASURLClassLoader.java:171), org
.glassfish.javaee.full.deployment.EarClassLoader.preDestroy(EarClassLoader.java:122), org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(ServiceLocatorImpl.java:1068), org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(Serv
iceLocatorImpl.java:1052), org.glassfish.internal.data.ApplicationInfo.clean(ApplicationInfo.java:490), com.sun.enterprise.v3.server.ApplicationLifecycle.unload(ApplicationLifecycle.java:1400), com.sun.enterprise.v3.server.Appl
icationLifecycle.undeploy(ApplicationLifecycle.java:1428), org.glassfish.deployment.admin.UndeployCommand.execute(UndeployCommand.java:431), com.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:556), com
.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:552), java.base/java.security.AccessController.doPrivileged(AccessController.java:400), java.base/javax.security.auth.Subject.doAs(Subject.java:453), com
.sun.enterprise.v3.admin.CommandRunnerImpl$2.execute(CommandRunnerImpl.java:551), com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunnerImpl.java:582), com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunne
rImpl.java:574), java.base/java.security.AccessController.doPrivileged(AccessController.java:400), java.base/javax.security.auth.Subject.doAs(Subject.java:453), com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRun
nerImpl.java:573), com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:1497), com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1879), com.sun.enterprise.v3
.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1755), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:272), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.
java:240), org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:294), org.glassfish.admin.rest.resources.TemplateRestResource.runCommand(TemplateRestResource.java:570), org.glassfish.admin.rest.resources.Tem
plateRestResource.doDelete(TemplateRestResource.java:307), org.glassfish.admin.rest.resources.TemplateRestResource.delete(TemplateRestResource.java:190), java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMe
thodHandleAccessor.java:103), java.base/java.lang.reflect.Method.invoke(Method.java:580), org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.
java:52), org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:146), org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.inv
oke(AbstractJavaResourceMethodDispatcher.java:189), org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176), org.glassfish.jer
sey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:93), org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:478), org.glassfis
h.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:400), org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:81), org.glassfish.jersey.server.ServerRuntime$1.run(Se
rverRuntime.java:274), org.glassfish.jersey.internal.Errors$1.call(Errors.java:248), org.glassfish.jersey.internal.Errors$1.call(Errors.java:244), org.glassfish.jersey.internal.Errors.process(Errors.java:292), org.glassfish.jer
sey.internal.Errors.process(Errors.java:274), org.glassfish.jersey.internal.Errors.process(Errors.java:244), org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266), org.glassfish.jersey.server.Serv
erRuntime.process(ServerRuntime.java:253), org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:696), org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:367)
, org.glassfish.admin.rest.adapter.RestAdapter$2.service(RestAdapter.java:335), org.glassfish.admin.rest.adapter.RestAdapter.service(RestAdapter.java:189), org.glassfish.admin.rest.adapter.RestManagementAdapter.service(RestMana
gementAdapter.java:66), com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:520), com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:217), org.glassfis
h.grizzly.http.server.HttpHandler.runService(HttpHandler.java:174), org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:153), org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.ja
va:196), org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:88), org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:246), org.glassfish.grizzly.filterchain
.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:178), org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:118), org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultF
ilterChain.java:96), org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:51), org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:510), org.glassfish.grizzly.strategies.Abstra
ctIOStrategy.fireIOEvent(AbstractIOStrategy.java:82), org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:83), org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.ru
n(WorkerThreadIOStrategy.java:101), org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:535), org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:515), java.base/java.lang.Thread.run(Thread.java:1583)] Parent -> org.glassfish.internal.api.DelegatingClassLoader@2437c706
 was requested to find class org.omnifaces.cdi.eager.EagerBeansRepository after done was invoked from the following stack trace
java.lang.Throwable
        at com.sun.enterprise.loader.ASURLClassLoader.findClassData(ASURLClassLoader.java:791)
        at com.sun.enterprise.loader.ASURLClassLoader.findClass(ASURLClassLoader.java:704)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)
        at com.sun.enterprise.loader.CurrentBeforeParentClassLoader.loadClass(CurrentBeforeParentClassLoader.java:83)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
        at com.sun.enterprise.loader.CachingReflectionUtil.lambda$getClassFromCache$0(CachingReflectionUtil.java:61)
        at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
        at com.sun.enterprise.loader.CachingReflectionUtil.getClassFromCache(CachingReflectionUtil.java:59)
        at com.sun.enterprise.loader.CacheCleaner.clearOmniFacesCache(CacheCleaner.java:79)
        at com.sun.enterprise.loader.CacheCleaner.clearCaches(CacheCleaner.java:51)
        at com.sun.enterprise.loader.ASURLClassLoader.done(ASURLClassLoader.java:211)
        at com.sun.enterprise.loader.ASURLClassLoader.preDestroy(ASURLClassLoader.java:171)
        at org.glassfish.javaee.full.deployment.EarClassLoader.preDestroy(EarClassLoader.java:122)
        at org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(ServiceLocatorImpl.java:1068)
        at org.jvnet.hk2.internal.ServiceLocatorImpl.preDestroy(ServiceLocatorImpl.java:1052)
        at org.glassfish.internal.data.ApplicationInfo.clean(ApplicationInfo.java:490)
        at com.sun.enterprise.v3.server.ApplicationLifecycle.unload(ApplicationLifecycle.java:1400)
        at com.sun.enterprise.v3.server.ApplicationLifecycle.undeploy(ApplicationLifecycle.java:1428)
        at org.glassfish.deployment.admin.UndeployCommand.execute(UndeployCommand.java:431)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:556)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$2$1.run(CommandRunnerImpl.java:552)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at java.base/javax.security.auth.Subject.doAs(Subject.java:453)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$2.execute(CommandRunnerImpl.java:551)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunnerImpl.java:582)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$3.run(CommandRunnerImpl.java:574)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at java.base/javax.security.auth.Subject.doAs(Subject.java:453)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:573)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl.doCommand(CommandRunnerImpl.java:1497)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1879)
        at com.sun.enterprise.v3.admin.CommandRunnerImpl$ExecutionContext.execute(CommandRunnerImpl.java:1755)
        at org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:272)
        at org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:240)
        at org.glassfish.admin.rest.utils.ResourceUtil.runCommand(ResourceUtil.java:294)
        at org.glassfish.admin.rest.resources.TemplateRestResource.runCommand(TemplateRestResource.java:570)
        at org.glassfish.admin.rest.resources.TemplateRestResource.doDelete(TemplateRestResource.java:307)
        at org.glassfish.admin.rest.resources.TemplateRestResource.delete(TemplateRestResource.java:190)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:146)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:189)
        at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:93)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:478)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:400)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:81)
        at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:274)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
        at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266)
        at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:253)
        at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:696)
        at org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:367)
        at org.glassfish.admin.rest.adapter.RestAdapter$2.service(RestAdapter.java:335)
        at org.glassfish.admin.rest.adapter.RestAdapter.service(RestAdapter.java:189)
        at org.glassfish.admin.rest.adapter.RestManagementAdapter.service(RestManagementAdapter.java:66)
        at com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:520)
        at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:217)
        at org.glassfish.grizzly.http.server.HttpHandler.runService(HttpHandler.java:174)
        at org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:153)
        at org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.java:196)
        at org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:88)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:246)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:178)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:118)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultFilterChain.java:96)
        at org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:51)
        at org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:510)
        at org.glassfish.grizzly.strategies.AbstractIOStrategy.fireIOEvent(AbstractIOStrategy.java:82)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:83)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.run(WorkerThreadIOStrategy.java:101)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:535)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:515)
        at java.base/java.lang.Thread.run(Thread.java:1583)
|#]

lprimak · 2025-02-08T02:03:21Z

I was able to reproduce the problem. It seems I forgot to re-test my sample app, just more sophisticated ones,
which for some reason, don't have the same issue :) Thanks for checking!
Should be an easy fix. Stay tuned.

…I-enabled library JARs - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching

lprimak · 2025-02-08T03:14:58Z

@luiseufrasio Fixed. Thank you

luiseufrasio

LGTM! Deploy and Undeploy are ok now. I also did the manual tests and they worked well.

lprimak changed the title ~~bugfix: passing BeanManager in EAR deployment's invocation state object~~ bugfix: Split CDI bean deployment when multiple WARs exist in an EAR Oct 28, 2024

lprimak commented Oct 28, 2024

View reviewed changes

appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java Outdated Show resolved Hide resolved

lprimak force-pushed the cdi-ear-exception branch from 1c8a517 to 93071cf Compare October 28, 2024 17:29

lprimak force-pushed the cdi-ear-exception branch 2 times, most recently from 89ef769 to 4a79348 Compare November 19, 2024 22:49

lprimak force-pushed the cdi-ear-exception branch from 61c4079 to 2471951 Compare November 21, 2024 07:37

felixif mentioned this pull request Nov 26, 2024

Bug Report: ClassLoader leak when Timer Service is used #7078

Closed

lprimak marked this pull request as ready for review November 26, 2024 20:17

lprimak marked this pull request as draft November 27, 2024 22:21

lprimak force-pushed the cdi-ear-exception branch from 766eb3e to d2fbb5a Compare November 28, 2024 00:08

lprimak marked this pull request as ready for review November 28, 2024 00:08

lprimak mentioned this pull request Nov 28, 2024

FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast deployments #7097

Open

kalinchan reviewed Nov 30, 2024

View reviewed changes

appserver/web/war-util/pom.xml Outdated Show resolved Hide resolved

lprimak force-pushed the cdi-ear-exception branch from 734fc05 to ad4885b Compare December 4, 2024 20:09

Pandrex247 changed the title ~~bugfix: Split CDI bean deployment when multiple WARs exist in an EAR~~ FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR Dec 5, 2024

lprimak force-pushed the cdi-ear-exception branch 2 times, most recently from 975cb97 to a4f4f36 Compare December 12, 2024 04:15

lprimak requested review from kalinchan and Pandrex247 January 18, 2025 18:47

lprimak mentioned this pull request Jan 23, 2025

[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain #7165

Draft

26 tasks

lprimak force-pushed the cdi-ear-exception branch from c718c36 to 0e0cd0a Compare January 29, 2025 18:38

luiseufrasio self-requested a review January 31, 2025 13:09

lprimak force-pushed the cdi-ear-exception branch from 07b7fda to d720198 Compare February 1, 2025 00:01

luiseufrasio requested changes Feb 4, 2025

View reviewed changes

lprimak force-pushed the cdi-ear-exception branch from 9362adb to 5475ead Compare February 8, 2025 03:11

lprimak requested a review from luiseufrasio February 8, 2025 03:12

lprimak force-pushed the cdi-ear-exception branch from 1ce7a13 to f414137 Compare February 8, 2025 03:13

luiseufrasio approved these changes Feb 10, 2025

View reviewed changes

Pandrex247 merged commit 0f80a5a into payara:main Feb 10, 2025
1 check passed

lprimak deleted the cdi-ear-exception branch February 10, 2025 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032

FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032

lprimak commented Oct 18, 2024 •

edited

Loading

lprimak commented Oct 28, 2024

Pandrex247 commented Oct 28, 2024

lprimak commented Oct 28, 2024

lprimak commented Nov 10, 2024

lprimak commented Nov 10, 2024 •

edited

Loading

lprimak commented Nov 21, 2024

lprimak commented Nov 26, 2024

lprimak commented Nov 27, 2024

lprimak commented Nov 27, 2024

lprimak commented Nov 28, 2024

lprimak commented Jan 20, 2025

luiseufrasio commented Jan 31, 2025

luiseufrasio commented Jan 31, 2025

lprimak commented Jan 31, 2025 •

edited

Loading

luiseufrasio left a comment

lprimak commented Feb 4, 2025

lprimak commented Feb 4, 2025

luiseufrasio commented Feb 4, 2025

lprimak commented Feb 4, 2025

luiseufrasio commented Feb 6, 2025

lprimak commented Feb 8, 2025

lprimak commented Feb 8, 2025

luiseufrasio left a comment

FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032

FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032

Conversation

lprimak commented Oct 18, 2024 • edited Loading

Description

Important Info

Testing

lprimak commented Oct 28, 2024

Pandrex247 commented Oct 28, 2024

lprimak commented Oct 28, 2024

lprimak commented Nov 10, 2024

lprimak commented Nov 10, 2024 • edited Loading

lprimak commented Nov 21, 2024

lprimak commented Nov 26, 2024

lprimak commented Nov 27, 2024

lprimak commented Nov 27, 2024

lprimak commented Nov 28, 2024

lprimak commented Jan 20, 2025

luiseufrasio commented Jan 31, 2025

luiseufrasio commented Jan 31, 2025

lprimak commented Jan 31, 2025 • edited Loading

luiseufrasio left a comment

Choose a reason for hiding this comment

lprimak commented Feb 4, 2025

lprimak commented Feb 4, 2025

luiseufrasio commented Feb 4, 2025

lprimak commented Feb 4, 2025

luiseufrasio commented Feb 6, 2025

lprimak commented Feb 8, 2025

lprimak commented Feb 8, 2025

luiseufrasio left a comment

Choose a reason for hiding this comment

lprimak commented Oct 18, 2024 •

edited

Loading

lprimak commented Nov 10, 2024 •

edited

Loading

lprimak commented Jan 31, 2025 •

edited

Loading