Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast deployments #7097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 28, 2024

Description

Dependencies can be copied to <domain_dir>/lib/warlibs/ and use no-dependency skinny-war
for deployments, significantly improving deployment times.
This can be done by layered docker deployment as well.
This will reduce application redeployment times by orders of magnitude

Orders-of-magnitude performance improvement achieved

Able to deploy real applications in half a second on my machine that used to take 15+ seconds

Fixes #6405

Important info

PR #7165 depends on this PR

Documentation updates

Applications need to be deployed with the following snippet to asadmin: --properties warlibs=true to take advantage of shared WAR libraries. This is to prevent unnecessary loading of shared libraries with non-development applications, such as admin console or other applications that will fail if shared WAR libraries are loaded.

Testing

Tested skinny WAR deployment

@lprimak
Copy link
Contributor Author

lprimak commented Dec 4, 2024

@Pandrex247 This one should be ready to go as soon as it's dependent #7032 is merged

@Pandrex247 Pandrex247 changed the title Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments Dec 5, 2024
@lprimak lprimak marked this pull request as ready for review December 6, 2024 02:45
@lprimak lprimak force-pushed the warlib branch 3 times, most recently from c9f272a to 3a59025 Compare December 12, 2024 04:19
@lprimak
Copy link
Contributor Author

lprimak commented Jan 20, 2025

@Pandrex247 this one is building a bit of a backlog now :)

@Pandrex247
Copy link
Member

@lprimak
I haven't forgotten you or your PRs 😝

We've recently been dealing with a number of high priority customer issues, internal targets, and attempting to catch up with and start contributing towards Jakarta EE 11 (particularly the Platform TCK and Jakarta Data).

Your two PRs don't look quick to review (particularly the CDI in EARs one!), so have unfortunately kept not making the cut for inclusion in our sprints. I do keep mentioning them during backlog grooming though, particularly since they've been open for quite a while now.

@lprimak
Copy link
Contributor Author

lprimak commented Jan 21, 2025

Thanks, the CDI-in-EAR one does the "heavy lift" to get things working for the other two performance PRs, unfortunately I couldn't make it any smaller :)

@lprimak
Copy link
Contributor Author

lprimak commented Feb 10, 2025

I have now re-based this PR, so now it's the "top of the stack"
Thank you

@lprimak lprimak changed the title FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast deployments Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI not scanning bean libraries in domain applib or lib directories/FISH-7871
2 participants