Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-648 Fix patroni-version-check #1071

Merged
merged 3 commits into from
Mar 6, 2025
Merged

K8SPG-648 Fix patroni-version-check #1071

merged 3 commits into from
Mar 6, 2025

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Mar 6, 2025

K8SPG-648 Powered by Pull Request Badge

DESCRIPTION

Problem:
The operator triggers the patroni-version-check only when the .spec.postgresVersion field is updated. However, if the user updates the images without modifying this field, the version check is not triggered, leading to an incorrect patroni version in the .status. This also results in a persistent error: get latest commit timestamp: primary pod not found.

Solution:
Start the patroni-version-check pod after all instance pods have been updated with the new image. The operator will determine this by comparing the new .status.postgres.imageID field with the image IDs of the instance pods.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

egegunes
egegunes previously approved these changes Mar 6, 2025
gkech
gkech previously approved these changes Mar 6, 2025
@pooknull pooknull dismissed stale reviews from egegunes and gkech via 9ab5634 March 6, 2025 19:44
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring failure
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 9ab5634
image: perconalab/percona-postgresql-operator:PR-1071-9ab563432

@hors hors changed the title Fix patroni-version-check K8SPG-648 Fix patroni-version-check Mar 6, 2025
@hors hors merged commit 411a397 into main Mar 6, 2025
16 of 17 checks passed
@hors hors deleted the fix-patroni-version-check branch March 6, 2025 21:09
jvpasinatto pushed a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants