Skip to content

fix compatibility with Pod::Usage #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

fix compatibility with Pod::Usage #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
442d3b8
rename heading filter internal field to more specific name
haarg May 13, 2025
9037c30
rename select method to set_heading_select to avoid conflicts
haarg May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/Pod/Simple/BlackBox.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ sub parse_lines { # Usage: $parser->parse_lines(@lines)
sub _maybe_handle_element_start {
my $self = shift;
return $self->_handle_element_start(@_)
if !$self->{filter};
if !$self->{heading_filter};

my ($element_name, $attr) = @_;

Expand All @@ -631,7 +631,7 @@ sub _maybe_handle_element_start {
sub _maybe_handle_element_end {
my $self = shift;
return $self->_handle_element_end(@_)
if !$self->{filter};
if !$self->{heading_filter};

my ($element_name, $attr) = @_;

Expand Down Expand Up @@ -665,7 +665,7 @@ sub _maybe_handle_element_end {
sub _maybe_handle_text {
my $self = shift;
return $self->_handle_text(@_)
if !$self->{filter};
if !$self->{heading_filter};

my ($text) = @_;

Expand All @@ -685,7 +685,7 @@ sub _filter_allows {
my $self = shift;
my @headings = @_;

my $filter = $self->{filter}
my $filter = $self->{heading_filter}
or return 1;

SPEC: for my $spec ( @$filter ) {
Expand All @@ -703,11 +703,11 @@ sub _filter_allows {
return 0;
}

sub select {
sub set_heading_select {
my $self = shift;
my (@selections) = @_;

my $filter = $self->{filter} ||= [];
my $filter = $self->{heading_filter} ||= [];
if (@selections && $selections[0] eq '+') {
shift @selections;
}
Expand Down
2 changes: 1 addition & 1 deletion t/filter-html.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ sub convert {
$parser->html_header('');
$parser->html_footer('');
$parser->output_string(\$out);
$parser->select(@$select);
$parser->set_heading_select(@$select);

$parser->parse_string_document($pod);
return $out;
Expand Down
2 changes: 1 addition & 1 deletion t/filter.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sub convert {
my $out = '';
my $parser = Pod::Simple::JustPod->new;
$parser->output_string(\$out);
$parser->select(@$select);
$parser->set_heading_select(@$select);

$parser->parse_string_document($pod);
return $out;
Expand Down
Loading