fix compatibility with Pod::Usage #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod::Simple has a 'filter' method already, so having an unrelated 'filter' field could be confusing.
Pod::Usage subclasses Pod::Simple and implements its own select method. That method tries to implement its own behavior but if a select method exists in the parent it will call that instead. This is for compatibility with inheriting from Pod::Parser instead. Avoid that compatibility issue by renaming the select method. It has only been available in a stable release for a few days and isn't yet documented, so it's pretty unlikely anyone is using it yet.
Contributor
Author
|
This was reported as Perl/perl5#23280 but is really just a problem with this module. |
khwilliamson
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.