Add tests for UTF8 characters in table definition and errors #467
+240
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-josef-spacek
force-pushed
the
add_utf8_jp_test
branch
from
e773891 to
e7ee31b
Compare
|
Still WIP |
michal-josef-spacek
force-pushed
the
add_utf8_jp_test
branch
2 times, most recently
from
02a3357 to
fe8cae9
Compare
michal-josef-spacek
changed the title
The tests are taken from DBD::MariaDB and adopted to DBD::mysql. Testing is provided on Japanese and Chinese characters. There are two test files: * one for testing of utf8/utf8mb4 identifiers * one for testing of utf8 error messages There are three runs of all tests in both test files: * one without mysql_enable_utf8 option * one with enabled mysql_enable_utf8 option * one with enabled mysql_enable_utf8mb4 option There are XXX comments for situations which not follow mysql_enable_utf8/mb4 option.
michal-josef-spacek
force-pushed
the
add_utf8_jp_test
branch
from
fe8cae9 to
d66c90d
Compare
|
PR is finished, any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for UTF8 characters in table definition and errors
The tests are taken from DBD::MariaDB and adopted to DBD::mysql.
Testing is provided on Japanese and Chinese characters.
There are two test files:
There are three runs of all tests in both test files:
There are XXX comments for situations which not follow
mysql_enable_utf8/mb4 option.