Add ignore_warnings_on_exit and ignore_errors_on_exit options
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a non-zero error code in the presence of warnings or errors respectively
2) allow true/false as well as 1/0 3) pass the env variable from the input
|
Hey @LennyN95 , thanks for your contribution. I've just taken a look over the code and added some tweaks. Can I get your opinion on my changes before I merge? I've allowed the values 'true' and 'false' instead of just 1 and 0, because I think it's more intuitive in the yaml config. |
|
Hey @g105b, thx for looking into this! I kept it close to the CS cli but I agree with you it's more intuitive and I personally like the true/false better. |
|
Just to clarify - you can still use 0 or 1, but I've allowed false/true to be optionally used. Thank you, I'll merge this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters
ignore_warnings_on_exitandignore_errors_on_exitto avoid a non-zero error code in the presence of warnings or errors respectively (see #2).