Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_warnings_on_exit and ignore_errors_on_exit options #3

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add ignore_warnings_on_exit and ignore_errors_on_exit options #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b7d4fe
add ignore_warnings_on_exit and ignore_errors_on_exit options to avoi…
LennyN95 Oct 30, 2024
4f7a2a1
1) fix a typo in "description"pass
Nov 18, 2024
d414a01
normalise true/false values into the phpcs 1/0 expected values
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ The following configuration options are available:
+ `severity` - The minimum severity required to display an error or warning
+ `error_severity` - The minimum severity required to display an error
+ `warning_severity` - The minimum severity required to display a warning
+ `ignore_warnings_on_exit` - Exit with a zero error code despite the presence of warnings (1 = true, default 0 = false).
+ `ignore_errors_on_exit` - xit with a zero error code despite the presence of errors (1 = true, default 0 = false).
+ `args` - Extra arguments to pass to the phpcs binary

If you require other configurations of PHPMD, please request them in the [Github issue tracker].
Expand Down
10 changes: 10 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ inputs:
description: The minimum severity required to display a warning
required: false

ignore_warnings_on_exit:
description: Exit with a zero error code despite the presence of warnings
required: false

ignore_errors_on_exit:
description: Exit with a zero error code despite the presence of errors
required: false

args:
description: Extra arguments to pass to the phpcs binary
required: false
Expand Down Expand Up @@ -109,6 +117,8 @@ runs:
ACTION_SEVERITY: ${{ inputs.severity }}
ACTION_ERROR_SEVERITY: ${{ inputs.error_severity }}
ACTION_WARNING_SEVERITY: ${{ inputs.warning_severity }}
ACTION_IGNORE_WARNINGS_ON_EXIT: ${{ inputs.ignore_warnings_on_exit }}
ACTION_IGNORE_ERRORS_ON_EXIT: ${{ inputs.ignore_errors_on_exit }}
ACTION_ARGS: ${{ inputs.args }}

id: phpcs_run
Expand Down
20 changes: 20 additions & 0 deletions phpcs-action.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,26 @@ then
command_string+=(--warning-severity="$ACTION_WARNING_SEVERITY")
fi

if [ -n "$ACTION_IGNORE_WARNINGS_ON_EXIT" ]
then
case "$ACTION_IGNORE_WARNINGS_ON_EXIT" in
'true'|'1') normalised_value=1 ;;
'false'|'0') normalised_value=0 ;;
*) normalised_value=0 ;;
esac
command_string+=(--runtime-set ignore_warnings_on_exit "$normalised_value")
fi

if [ -n "$ACTION_IGNORE_ERRORS_ON_EXIT" ]
then
case "$ACTION_IGNORE_ERRORS_ON_EXIT" in
'true'|'1') normalised_value=1 ;;
'false'|'0') normalised_value=0 ;;
*) normalised_value=0 ;;
esac
command_string+=(--runtime-set ignore_errors_on_exit "$ACTION_IGNORE_ERRORS_ON_EXIT")
fi

if [ -n "$ACTION_ARGS" ]
then
command_string+=($ACTION_ARGS)
Expand Down