Add migration to handle webpush subscriptions on extension purge.

[rxu]

Closes #5.

[rxu]

TODO: add moving extension tables data over corresponding phpBB 4.0 tables etc.

[rxu]

This looks weird though so there should be some instruction on how to use this to avoid board mess and/or crash.
F.e. after upgrading board to phpBB 4.0 the extension should be purged 1st while the board is still disabled so that users didn't create any webpush subscriptions yet.

[iMattPro]

Oh yeah. We missed that I guess. We should prefix everything that could possibly conflict with the 4.0 implantation

…

On Jan 2, 2024 at 8:03 AM -0800, rxu ***@***.***>, wrote: @rxu commented on this pull request. In migrations/handle_subscriptions.php: > + * Otherwise remove all subscriptions + */ + $sql = $core_webpush_exists ? + 'UPDATE ' . $user_notifications_table . " + SET method = '" . $this->db->sql_escape('notification.method.webpush') . "' + WHERE method = '" . $this->db->sql_escape('phpbb.wpn.notification.method.webpush') . "'" : + + 'DELETE FROM ' . $user_notifications_table . " + WHERE method = '" . $this->db->sql_escape('phpbb.wpn.notification.method.webpush') . "'"; + + $this->db->sql_query($sql); + } + + public function copy_subscription_tables() + { + $core_notification_push_table = $this->table_prefix . 'notification_push'; > Also should we copy over the API keys and enable/disabled configs too? Oh, should we then rename current ext config parameters to something wpn-prefixed? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

[rxu]

We probably need to unit-test this migration somehow, f.e. create fixtures with tables and configs including ones from 4.0 PR, run the migration and assert exported values.