pkp/pkp-lib#7135 Multiple author affiliations

[GaziYucel]

Related issues:

• Need to support multiple author affiliations pkp-lib#7135

Pull requests:

• pkp/pkp-lib#7135 Multiple author affiliations pkp-lib#10460
• pkp/pkp-lib#7135 Multiple author affiliations #417
• pkp/pkp-lib#7135 Multiple author affiliations ojs#4469
• pkp/pkp-lib#7135 Multiple author affiliations (ROR) omp#1819
• pkp/pkp-lib#7135 Multiple author affiliations googleScholar#23
• pkp/pkp-lib#7135 Multiple author affiliations jatsTemplate#68
• pkp/pkp-lib#7135 Multiple author affiliations asmecher/grobidMetadataExtractor#1
• fix changing author metadata on submission locale change quickSubmit#102

[GaziYucel]

I am waiting for a variant of the FieldBaseSuggest.vue component. After this, this PR can be wrapped up.

[GaziYucel]

I have done a force push, because there was an error rebasing a couple of days ago. The PR is clean and up to date again.

[GaziYucel]

Hi @jardakotesovec,

I have implemented everything we discussed and all seems to work.

There are some notes:

• you mentioned that Blessie was working on a variant of FieldBaseSuggest.vue which I can use
  Add customization support for FieldBaseAutosuggest options pkp-lib#10624
• I have used <input type="text" for input fields. It would be better to have a very simple Vue component to use. This would have the following advantages:
  • less clutter and cleaner code
  • better accessibility
• error handling
  • this is not implemented a la OJS
  • the check I do: there should be a ROR or at least one name and the name should be the primary locale
  • if this is not true, I disable the 'Add' button
  • saving the form is still enabled
• UI design
  • @Devika008 used a pie to show how many translations there are. I couldn't do this, because there is no component for this. I implemented "MultilingualProgress" instead
  • Devika placed the text/link "# of # translations completed" below the input fields. I moved this to above, because this makes the interface less jumpy

[GaziYucel]

Hi @jardakotesovec,

I have implemented the new FieldRorAutosuggest (FieldAffiliationsRorAutoSuggest) component of @blesildaramirez.

I think the PR is ready for review now. Thanks.

@bozana: fyi

[GaziYucel]

I am copying this from Mattermost to here, so it's on the list to check.

As mentioned before, I think AbortController in src/composables/useFetch.js is not working as intended. Removing or adding async / await does not help.

You can recreate this with the following two files, which are also in this PR.

• src/components/Form/fields/FieldAffiliationsTest.stories.js
• src/components/Form/fields/FieldAffiliationsTest.vue

[jardakotesovec]

Thank you for the updates. Could you please check couple more? Should be easy updates.

[jardakotesovec]

Do we need to copy this from form to the field? By looking to FieldBase I see that it should be getting these two information as props - primaryLocale and locales.

[GaziYucel]

How would I get these from FieldBase in my component FieldAffiliations? Can you help me with this?

[jardakotesovec]

This means that its being passed to all fields. Including your one. So if you just add it to the FieldAffiliation props - it should become available to you.

[jardakotesovec]

At some point we should do some screen reader accessibility testing. But don't have bandwidth for that at this point.

I think its in good enough shape to be merged. Thank you for the hard work on this!