Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #226

Merged
merged 235 commits into from
Aug 1, 2015
Merged

Version 1.0 #226

merged 235 commits into from
Aug 1, 2015

Conversation

cpsievert
Copy link
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

cpsievert added 30 commits May 5, 2015 10:13
@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievert cpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert cpsievert merged commit b610dcf into master Aug 1, 2015
@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed re-design
3 participants