Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rule23-1.md #1434

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update Rule23-1.md #1434

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b5d174
Update Rule23-1.md
KarenWGard Jul 30, 2024
902196a
Update Rule23-1.md
KarenWGard Jul 31, 2024
0235f9f
Update Rule23-1.md
KarenWGard Nov 6, 2024
a73fcc7
Update Rule23-1.md
KarenWGard Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/section23/Rule23-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@
- get the hvac system from the hvac_system_id: `hvac_system = get_component_by_id(hvac_system_id)`
- get the heating system: `heating_system = hvac_system.heating_system`
- get the heatpump_low_shutoff_temperature = `heatpump_low_shutoff = heating_system.heatpump_low_shutoff_temperature`
- get the auxiliary heat high temperature shutoff = 'aux_heat_high_temp_shutoff = heating_system.heatpump_auxilliary_heat_high_shutoff_temperature`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last character needs to be corrected. Looks like a character is off making it so the python is not blue

- get the auxiliary heat energy source: `aux_heat_energy_source = heatpump_auxilliary_heat_type`
Copy link
Collaborator

@claperle claperle Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be modified to aux_heat_energy_source = heating_system.heatpump_auxilliary_heat_type


**Rule Assertion:**
- Case 1: The system type is 2 and the heatpump_low_shutoff is <= 17F, PASS: `if system_type == HVAC_SYS.2: if heatpump_low_shutoff <= 17: PASS`
- Case 2: The system type is 2 and the heatpump_low_shutoff is >25F, FAIL, provide a message: `elif system_type == HVAC_SYS.2:`
- `if heatpump_low_shutoff > 25: FAIL; note = "Fail because low temperature heat pump shutoff is above 25F for system 2. The modeled low temperature heat pump shutoff value is " + heatpump_low_shutoff
+ "."`
- Case 3: the system type is 2 and the heatpump_low_shutoff is between 17F and 25: UNDETERMINED; provide a message: `else: UNDETERMINED; note = "Undetermined because the low temperature shutoff is between 17F and 25F for System Type 2. Check with the rating authority to ensure correct shutoff temperature. Low shutoff temperature is currently modeled at: " heatpump_low_shutoff = "."`
- Case 4: the system type is 4 (we already know it's 4, because we've checked the 3 SYS 2 cases above), and the low shutoff temperature is <=10F: PASS: `if heatpump_low_shutoff <= 10F: PASS`
- Case 5: anything else, FAIL: `ELSE: Fail`
- Case 1: The auxiliary heat high temperature shutoff is greater than 40F, or the auxiliary heat energy source is anything other than electricity - FAIL: `if (aux_heat_high_temp_shutoff > 40) or (aux_heat_energy_source != "ELECTRIC_RESISTANCE"): FAIL`
- Case 2: The system type is 2 and the heatpump_low_shutoff is <= 17F OR tye system type is 4 and the heatpump_low_shutoff is <=10F, PASS: `if(system_type == HVAC_SYS.2 and heatpump_low_shutoff <= 17) or (system_type == HVAC_SYS.4 and heatpump_low_shutoff <= 10): PASS`
Copy link
Collaborator

@claperle claperle Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Appendix G basis for this, correct? Based on recent discussions within the commitee, I am not sure we should be making these assumptions; I know we decided on this approach previously but wonder if it is still appropriate. It does seem like a no brainer to use 17F but not sure about the 10F since there were comments about us "interpreting" 90.1 requirements which this kind of falls into.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that these minimum numbers come from the minimum temperature at which the heat pumps are rated based on the AHRI conditions from Table 6.8.1-2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but open to discussion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 10F is in those tables. 17F is though.

- Case 3: The system type is 2 and the heatpump_low_shutoff is >25F, FAIL, provide a message: `elif system_type == HVAC_SYS.2 && heatpump_low_shutoff > 25:`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of Ruby instead of python with the &&?

- `FAIL; note = "Fail because low temperature heat pump shutoff is above 25F for system 2. The modeled low temperature heat pump shutoff value is " + heatpump_low_shutoff + "."`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question of the 25F heat pump low shut off for System 2. Is this an interpretation from our side or is there a requirement that states this that I'm missing?

- Case 4: the system type is 2 and the heatpump_low_shutoff is between 17F and 25: UNDETERMINED; provide a message: `else: UNDETERMINED; note = "Undetermined because the low temperature shutoff is between 17F and 25F for System Type 2. Check with the rating authority to ensure correct shutoff temperature. Low shutoff temperature is currently modeled at: " heatpump_low_shutoff = "."`

**Notes:**

Expand Down
Loading