-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building DEB packages with podman & pbuilder #8
Conversation
@@ -0,0 +1,48 @@ | |||
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this information should be extractable from the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. This line looks like some XML schema definition that should always be the same. No?
…nd return its contents
56f8b9a
to
59d72f8
Compare
…ld not require dependencies install inside podman
…ding deb This is instead of copying repository into the container.
…ackage in Pgpm::Deb::Builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please rebase?
when "debian", "ubuntu" | ||
[ | ||
"build-essential", | ||
"postgresql-#{postgres_major_version}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postgres dependencies are added in the RPM spec / DEB control preparation based on Distribution
's methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments. Also, there is a minor conflict to be resolved again (sorry!)
lib/pgpm/package/make.rb
Outdated
super | ||
end | ||
|
||
def install_steps | ||
return [Pgpm::Commands::Make.new("install", "DESTDIR=$PGPM_BUILDROOT", "PG_CONFIG=$PG_CONFIG")] if makefile_present? | ||
|
||
case Pgpm::OS.in_scope.class.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And speaking of special-casing and the case I expanded on when it comes to configuring – this is the same issue – and an opportunity – to unify the procedure.
lib/pgpm/package/make.rb
Outdated
when "debian", "ubuntu" | ||
return [] | ||
when "rocky+epel-9", "redhat", "fedora" | ||
return [Pgpm::Commands::Make.new("PG_CONFIG=$PG_CONFIG")] if makefile_present? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And speaking of special-casing and the case I expanded on when it comes to configuring – this is the same issue – and an opportunity – to unify the procedure.
…ing `dh` in it (WIP)
…n deb rules + timescaledb package custom configure/install steps
…dependncies for rpm's side of timescaledb pkg
Nice things:
Gotchas:
lib/pgpm/deb/builder.rb#build()
to get the full picture.fakeroot
related, but do not affect the build. I had to usefakeroot pbuilder
, because SELinux would not allow me to mount/dev/*
in a rootless container.