Upgrade Noble #1242
Merged
Upgrade Noble #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can connect to any address so do not check that
|
Review changes with SemanticDiff. Analyzed 2 of 2 files.
|
pullapprove
bot
requested review from
lauckhart,
turon,
vves and
woody-apple
Apollon77
commented
Sep 27, 2024
lauckhart
approved these changes
Sep 28, 2024
# Conflicts: # package-lock.json # packages/nodejs-ble/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix controller usage after merge of latest PR.
Also document out "reset" because currently crashing and was also not really working before it seems
fixes #1120