-
Notifications
You must be signed in to change notification settings - Fork 58
Update SDK e2e test to reflect poetry changes #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK e2e test to reflect poetry changes #315
Conversation
@Srihari1192 The |
Test
|
@Srihari1192 That is because of resource limit for Ray head. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running locally on a kind cluster and it is failing for me also. I have added
head_cpus=1, head_memory=0.2,
to the cluster configuration but am still getting an error (I've tried increasing these also). The job is not reaching the desired complete
or failed
state. The end of the log looks like this...
Tried running in fork repo by setting min values for head and
|
I think test were failing because of Ingress is not supporting in Kind cluster.. It should work after the PR merged |
0f6d39b
to
1351512
Compare
4baf500
to
ffc2004
Compare
ca86142
to
7ee094b
Compare
c39c881
to
401bca9
Compare
b0746ac
to
50a5a9c
Compare
Add Ingress domain for sdk e2e test Revert "Add Ingress domain for sdk e2e test" This reverts commit ffc2004.
50a5a9c
to
e811c04
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
closes #250
What changes have been made
Updated the test
TestMNISTRayClusterSDK
to use poetry for installing CodeFlare SDK by replacing pipAdded the script
install-codeflare-sdk.sh
for installing codeflare-sdk using poetry and can reuse this in another testsVerification steps
Checks