renovate: reduce awssdk update frequency #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
renovate-awssdk
branch
from
23b0b1b to
41c58db
Compare
|
@snazy if this works, we should apply it to all nessie repos, wdyt? |
snazy
approved these changes
Dec 6, 2023
ajantha-bhat
reviewed
Dec 6, 2023
| { | ||
| matchManagers: ["maven", "gradle"], | ||
| matchPackageNames: ["software.amazon.awssdk:*"], | ||
| extends: ["schedule:weekly"], |
There was a problem hiding this comment.
Should we permanently disable it and manually update it only with Iceberg version bump?
Iceberg may expect the matching version of aws sdk from the release (But latest version will work as long as the compatibility is not broken)
There was a problem hiding this comment.
i think the cross engine tests (which dont run on github) would tell us if such an upgrade broke compatibility... imo reducing by factor 7 should be good enough for now.
XN137
added a commit
that referenced
this pull request
Dec 12, 2023
#485 did not work lets try using this instead: https://github.com/renovatebot/renovate/blob/main/docs/usage/configuration-options.md#matchpackageprefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its just too much in terms of commits and waste of CI resources:
also most (all?) of CI doesnt even use awssdk