Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: reduce awssdk update frequency #485

Merged
merged 1 commit into from
Dec 6, 2023
Merged

renovate: reduce awssdk update frequency #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@
matchManagers: ["maven", "gradle", "gradle-wrapper"],
matchUpdateTypes: ["major"],
automerge: false
}
},

// Reduce awssdk update frequency (which has daily releases)
{
matchManagers: ["maven", "gradle"],
matchPackageNames: ["software.amazon.awssdk:*"],
extends: ["schedule:weekly"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we permanently disable it and manually update it only with Iceberg version bump?
Iceberg may expect the matching version of aws sdk from the release (But latest version will work as long as the compatibility is not broken)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the cross engine tests (which dont run on github) would tell us if such an upgrade broke compatibility... imo reducing by factor 7 should be good enough for now.

},
],

// Max 50 PRs in total, 10 per hour
Expand Down