Skip to content

[PULP-399] Include data table for perf/scale blog post (2023-02) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

pedro-psb
Copy link
Member

The css was inlined for simpilcity, as mkdocs won't automatically add it as an asset without project-level config.

image

@pedro-psb pedro-psb requested a review from mdellweg March 19, 2025 19:52
@pedro-psb pedro-psb changed the title Include data table for perf/scale blog post (2023-02) [PULP-399] Include data table for perf/scale blog post (2023-02) Mar 19, 2025
The data was moved from:
https://github.com/pulp/pulpproject.org/tree/b037f642cc4d89eb438e32c90b707702e920b977/files/pulp_rpm_redirection_perf_and_scale_blog_post

The css was inlined for simpilcity, as mkdocs won't automatically add
it as an asset without project-level config.

Fixes pulp#113
@pedro-psb pedro-psb force-pushed the fix-blog-post-asset branch from 3b5c15e to dcf13dd Compare March 19, 2025 20:56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not nicely formatted.
Also why can't we serve the sheet.css next to the html?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've basically copied the original. Do you think I should run a formatter on it?

Also why can't we serve the sheet.css next to the html?

We can, but I believe we'd have to include it via the mkdocs extra css config, which doesn't seems right.
I mean, an html will be served directly, but not a css.

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever...

@mdellweg mdellweg merged commit afcaa90 into pulp:main Mar 20, 2025
4 checks passed
@pedro-psb pedro-psb deleted the fix-blog-post-asset branch March 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants