(maint) Add some new optional parameters for puppetserver testing #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwolfe
approved these changes
May 3, 2019
|
If we're going to swap the agent container over to Ubuntu in this PR can we reference the problems in the commit message and put a comment in the code about not using Alpine for now? Relevant issues - moby/libnetwork#2371, microsoft/opengcs#303 There's a lot of context behind that seemingly simple change that I think we should document for posterity |
Iristyle
suggested changes
May 3, 2019
|
yeah, I thought I had it in the commit messages but apparently that was in the puppetserver PR or rebased away |
When testing with the `puppet/puppet-agent-alpine` image on windows systems with LCOW we had intermittent failures in DNS resolution that occurred fairly regularly. It seems to be specifically interaction between the base alpine (3.8 and 3.9) images with windows/LCOW. Two issues related to this issue are moby/libnetwork#2371 and microsoft/opengcs#303
underscorgan
force-pushed
the
maint/master/gem_updates_for_puppetserver
branch
from
c52cfd8 to
4deb920
Compare
Iristyle
changed the title
Iristyle
approved these changes
May 3, 2019
Iristyle
changed the title
Iristyle
added a commit
that referenced
this pull request
Apr 9, 2021
(maint) Add some new optional parameters for puppetserver testing / switch to Ubuntu agent container for testing
Iristyle
added a commit
that referenced
this pull request
Apr 9, 2021
(maint) Update to latest agent container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.