Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against OS family rather than name #667

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Test against OS family rather than name #667

merged 1 commit into from
Oct 16, 2020

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Oct 13, 2020

This then includes proper RHEL as well as CentOS. The module would (correctly) fail to work on CentOS 6 but wouldn't fail on RHEL 6.

This then includes proper RHEL as well as CentOS.
@bodgit bodgit requested a review from a team as a code owner October 13, 2020 11:57
@puppet-community-rangefinder
Copy link

docker is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 23 modules (near match):

This module is declared in 6 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #667 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   22.37%   22.37%           
=======================================
  Files          20       20           
  Lines         751      751           
=======================================
  Hits          168      168           
  Misses        583      583           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a6d69...ef54fcc. Read the comment docs.

@michaeltlombardi michaeltlombardi merged commit 8a2a029 into puppetlabs:main Oct 16, 2020
@bodgit bodgit deleted the redhat-vs-centos branch February 4, 2021 10:44
@PolaricEntropy
Copy link
Contributor

This makes the module fail on Amazon Linux 2 (REHL7) that has os.family=RedHat but os.release.major 2. Worked fine before when it checked CentOS since then it didn't match on the fail statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants