Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to puppet-module-gems 1.0, pdk-templates and new rubocop #1352

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Dec 16, 2020

No description provided.

@DavidS DavidS requested a review from a team as a code owner December 16, 2020 14:52
@puppet-community-rangefinder
Copy link

mysql::normalise_and_deepmerge is a function

Breaking changes to this file WILL impact these 1 modules (exact match):

mysql::password is a function

Breaking changes to this file WILL impact these 7 modules (exact match):

mysql::strip_hash is a function

that may have no external impact to Forge modules.

mysql_password is a function

Breaking changes to this file WILL impact these 17 modules (exact match):
Breaking changes to this file MAY impact these 26 modules (near match):

mysql_database is a type

Breaking changes to this file WILL impact these 9 modules (exact match):
Breaking changes to this file MAY impact these 9 modules (near match):

mysql_datadir is a type

Breaking changes to this file MAY impact these 1 modules (near match):

mysql_grant is a type

Breaking changes to this file MAY impact these 33 modules (near match):

mysql_plugin is a type

Breaking changes to this file MAY impact these 1 modules (near match):

mysql_user is a type

Breaking changes to this file MAY impact these 31 modules (near match):

This module is declared in 143 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

Codecov Report

Merging #1352 (d84e65c) into main (adcb5d3) will decrease coverage by 5.42%.
The diff coverage is 46.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
- Coverage   55.75%   50.33%   -5.43%     
==========================================
  Files          22       22              
  Lines        1051     1055       +4     
==========================================
- Hits          586      531      -55     
- Misses        465      524      +59     
Impacted Files Coverage Δ
lib/facter/mysql_server_id.rb 87.50% <ø> (ø)
lib/facter/mysql_version.rb 100.00% <ø> (ø)
lib/facter/mysqld_version.rb 100.00% <ø> (ø)
.../puppet/functions/mysql/normalise_and_deepmerge.rb 0.00% <0.00%> (ø)
lib/puppet/functions/mysql/password.rb 0.00% <0.00%> (ø)
lib/puppet/functions/mysql/strip_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/mysql_password.rb 0.00% <ø> (ø)
lib/puppet/provider/mysql.rb 37.50% <0.00%> (+0.51%) ⬆️
lib/puppet/provider/mysql_datadir/mysql.rb 0.00% <ø> (ø)
lib/puppet/provider/mysql_grant/mysql.rb 16.49% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fc2d2...d84e65c. Read the comment docs.

@pmcmaw pmcmaw merged commit b7b90c2 into main Jan 14, 2021
@DavidS DavidS deleted the pdksync branch January 14, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants