Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap scipy.signal.gauss_spline as Op #1264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Wrap scipy.signal.gauss_spline as Op #1264

wants to merge 2 commits into from

Conversation

PabloRoque
Copy link

@PabloRoque PabloRoque commented Mar 5, 2025 •
edited by github-actions bot
Loading

Description

Wraps spicy.signal.gauss_spline as a pytensor Op

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1264.org.readthedocs.build/en/1264/

@PabloRoque PabloRoque changed the title Attempt to add support for scipy.signal.gauss_spline Wrap scipy.signal.gauss_spline as Op Mar 5, 2025
ricardoV94
ricardoV94 reviewed Mar 5, 2025
View reviewed changes
pytensor/tensor/ssignal.py
@@ -0,0 +1,38 @@
import scipy.signal as scipy_signal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note that won't matter until the end of this PR but we probably want to do this import lazy to not slow down pytensor import. See #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloRoque @ricardoV94