Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap scipy.signal.gauss_spline as Op #1264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions pytensor/tensor/ssignal.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import scipy.signal as scipy_signal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note that won't matter until the end of this PR but we probably want to do this import lazy to not slow down pytensor import. See #1268


from pytensor.graph.basic import Apply
from pytensor.tensor import Op, as_tensor_variable
from pytensor.tensor.type import TensorType


class GaussSpline(Op):
__props__ = ("n",)

def __init__(self, n: int):
self.n = n

def make_node(self, knots):
knots = as_tensor_variable(knots)
if not isinstance(knots.type, TensorType):
raise TypeError("Input must be a TensorType")

if not isinstance(self.n, int) or self.n is None or self.n < 0:
raise ValueError("n must be a non-negative integer")

if knots.ndim < 1:
raise TypeError("Input must be at least 1-dimensional")

out = knots.type()
return Apply(self, [knots], [out])

def perform(self, node, inputs, output_storage):
[x] = inputs
[out] = output_storage
out[0] = scipy_signal.gauss_spline(x, self.n)

def infer_shape(self, fgraph, node, shapes):
return [shapes[0]]


def gauss_spline(x, n):
return GaussSpline(n)(x)
33 changes: 33 additions & 0 deletions tests/tensor/test_ssignal.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import numpy as np
import pytest
import scipy.signal as scipy_signal

from pytensor import function
from pytensor.tensor.ssignal import GaussSpline, gauss_spline
from pytensor.tensor.type import matrix
from tests import unittest_tools as utt


class TestGaussSpline(utt.InferShapeTester):
def setup_method(self):
super().setup_method()
self.op_class = GaussSpline
self.op = gauss_spline

@pytest.mark.parametrize("n", [-1, 1.5, None, "string"])
def test_make_node_raises(self, n):
a = matrix()
with pytest.raises(ValueError, match="n must be a non-negative integer"):
self.op(a, n=n)

def test_perform(self):
a = matrix()
f = function([a], self.op(a, n=10))
a = np.random.random((8, 6))
assert np.allclose(f(a), scipy_signal.gauss_spline(a, 10))

def test_infer_shape(self):
a = matrix()
self._compile_and_check(
[a], [self.op(a, 16)], [np.random.random((12, 4))], self.op_class
)