-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap scipy.signal.gauss_spline
as Op
#1264
Open
PabloRoque
wants to merge
2
commits into
pymc-devs:main
Choose a base branch
from
PabloRoque:implement-gauss-spline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import scipy.signal as scipy_signal | ||
|
||
from pytensor.graph.basic import Apply | ||
from pytensor.tensor import Op, as_tensor_variable | ||
from pytensor.tensor.type import TensorType | ||
|
||
|
||
class GaussSpline(Op): | ||
__props__ = ("n",) | ||
|
||
def __init__(self, n: int): | ||
self.n = n | ||
|
||
def make_node(self, knots): | ||
knots = as_tensor_variable(knots) | ||
if not isinstance(knots.type, TensorType): | ||
raise TypeError("Input must be a TensorType") | ||
|
||
if not isinstance(self.n, int) or self.n is None or self.n < 0: | ||
raise ValueError("n must be a non-negative integer") | ||
|
||
if knots.ndim < 1: | ||
raise TypeError("Input must be at least 1-dimensional") | ||
|
||
out = knots.type() | ||
return Apply(self, [knots], [out]) | ||
|
||
def perform(self, node, inputs, output_storage): | ||
[x] = inputs | ||
[out] = output_storage | ||
out[0] = scipy_signal.gauss_spline(x, self.n) | ||
|
||
def infer_shape(self, fgraph, node, shapes): | ||
return [shapes[0]] | ||
|
||
|
||
def gauss_spline(x, n): | ||
return GaussSpline(n)(x) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import numpy as np | ||
import pytest | ||
import scipy.signal as scipy_signal | ||
|
||
from pytensor import function | ||
from pytensor.tensor.ssignal import GaussSpline, gauss_spline | ||
from pytensor.tensor.type import matrix | ||
from tests import unittest_tools as utt | ||
|
||
|
||
class TestGaussSpline(utt.InferShapeTester): | ||
def setup_method(self): | ||
super().setup_method() | ||
self.op_class = GaussSpline | ||
self.op = gauss_spline | ||
|
||
@pytest.mark.parametrize("n", [-1, 1.5, None, "string"]) | ||
def test_make_node_raises(self, n): | ||
a = matrix() | ||
with pytest.raises(ValueError, match="n must be a non-negative integer"): | ||
self.op(a, n=n) | ||
|
||
def test_perform(self): | ||
a = matrix() | ||
f = function([a], self.op(a, n=10)) | ||
a = np.random.random((8, 6)) | ||
assert np.allclose(f(a), scipy_signal.gauss_spline(a, 10)) | ||
|
||
def test_infer_shape(self): | ||
a = matrix() | ||
self._compile_and_check( | ||
[a], [self.op(a, 16)], [np.random.random((12, 4))], self.op_class | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note that won't matter until the end of this PR but we probably want to do this import lazy to not slow down pytensor import. See #1268