-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support numba compiled sort
and argsort
functions
#1309
Support numba compiled sort
and argsort
functions
#1309
Conversation
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
It looks like there's some syntax that isn't python 3.10 compatible. We're following the numpy depreciation schedule, so we should still support python 3.10 for one more week |
Signed-off-by: Victor Garcia Reolid <[email protected]>
Aw indeed! I changed the syntax to be compatible with Python 3.10 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
+ Coverage 82.00% 82.02% +0.01%
==========================================
Files 188 203 +15
Lines 48478 48837 +359
Branches 8665 8691 +26
==========================================
+ Hits 39755 40058 +303
- Misses 6575 6627 +52
- Partials 2148 2152 +4
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change resquests, looks great so far
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Signed-off-by: Victor Garcia Reolid <[email protected]>
sort
and argsort
functionssort
and argsort
functions
Thanks for this! |
Description
This PR introduces Numba compiled function
sort
andargsort
for certain kind of sorting algorithms that are supported by Numba (See this).Related Issue
sort
andargsort
#1151Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1309.org.readthedocs.build/en/1309/