MAINT Move install, list, uninstall implementation to PackageManager #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
agriyakhetarpal
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Thanks, @ryanking13! The changes look good to me. Thanks for the reminder on Discord about the review.
| @@ -1,5 +1,5 @@ | |||
| from pathlib import Path | |||
| from typing import TYPE_CHECKING, Any | |||
| from typing import TYPE_CHECKING | |||
There was a problem hiding this comment.
An annotation about missing tests shows up here and in a few places below. I think we should restore Codecov at some point (not in this PR, of course).
There was a problem hiding this comment.
Yeah, but for now, we don't have a way to pass the test result inside Pyodide to the host (pyodide/pyodide#2873), so the coverage score is not that reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
install,list,uninstallfunctions into PakckageManager class. No functional changes are intended.The goal is to pass
CompatibilityLayeras a parameter of PackageManager so we can control the external dependency (Pyodide) more clearly instead of importing it everywhere.