Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config migration: float8* #1694

Merged
merged 19 commits into from
Feb 14, 2025
Merged

config migration: float8* #1694

merged 19 commits into from
Feb 14, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 10, 2025

Summary:

Migrates the following quantization workflow configs (old -> new):

  • float8_dynamic_activation_float8_weight -> Float8DynamicActivationFloat8WeightConfig
  • float8_static_activation_float8_weight -> Float8StaticActivationFloat8WeightConfig
  • float8_weight_only -> Float8WeightOnlyConfig

Please see #1690 for more details.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 11 commits January 22, 2025 08:49
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1694

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Feb 10, 2025
Summary:

TODO write me

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 26d4a037f251363bb27638078134920d279df1a9
ghstack-comment-id: 2649492752
Pull Request resolved: #1694
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@vkuzo vkuzo added the topic: bc-breaking Use this tag if this PR breaks backward compatibility label Feb 11, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Feb 11, 2025
Summary:

TODO write me

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f096aa90b0615af5a09f22a5964fd74f4f28f57c
ghstack-comment-id: 2649492752
Pull Request resolved: #1694
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Feb 11, 2025
Summary:

TODO write me

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 022867bb69b128401ef82751cf31a2b96007df69
ghstack-comment-id: 2649492752
Pull Request resolved: #1694
@vkuzo vkuzo mentioned this pull request Feb 11, 2025
@vkuzo vkuzo changed the title config migration: float* config migration: float8* Feb 11, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/19/head to main February 14, 2025 00:23
@vkuzo vkuzo merged commit 2e51872 into main Feb 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bc-breaking Use this tag if this PR breaks backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants