Skip to content

[moe training] refactor to share benchmarking and profiling utils #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: danielvegamyhre/stack/40
Choose a base branch
from

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 14, 2025

Stacked PRs:


[moe training] refactor to share benchmarking and profiling utils

MoE layer FSDP fwd + bwd bench

rm -rf /tmp/torchinductor_danvm; torchrun --nproc-per-node=8 --local-ranks-filter=0 benchmarks/prototype/moe_training/benchmark_moe_fsdp.py --compile  --recipe="fp8_rowwwise"

...
BF16 time: 100860.36600000001 us
Scaled time: 110353.22200000001 us
Speedup: 0.914x

Scaled grouped mm with dynamic quant fwd + bwd bench

rm -rf /tmp/torchinductor_danvm; torchrun --nproc-per-node=8 --local-ranks-filter=0 benchmarks/prototype/moe_training/benchmark_scaled_grouped_mm_dq.py --compile 

...

A_shape        B_shape             bf16_time_us    scaled_time_us  fp8_speedup
-------------  ----------------  --------------  ----------------  -------------
(16640, 5120)  (16, 8192, 5120)         10523.7           12889.3  0.816x

Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2767

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 43ffe7a with merge base 317179e (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
stack-info: PR: #2767, branch: danielvegamyhre/stack/41
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from 3401bb4 to 01ade5c Compare August 14, 2025 00:03
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 00:07
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
stack-info: PR: #2767, branch: danielvegamyhre/stack/41
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from 01ade5c to c02d02b Compare August 14, 2025 00:07
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 00:08
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 14, 2025
stack-info: PR: #2767, branch: danielvegamyhre/stack/41
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 01:04
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from c02d02b to 43ffe7a Compare August 14, 2025 01:04
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 01:05
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 01:44
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 01:45
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 05:51
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 05:51
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 21:27
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 21:28
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 22:23
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 22:23
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/40 to main August 14, 2025 23:20
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/40 August 14, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant