Skip to content

[moe training] add memory bandwidth calculations to kernel benchmarking scripts #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 14, 2025

Stacked PRs:


[moe training] add memory bandwidth calculations to kernel benchmarking scripts

documenting example torch.compile codegen for the 3d expert weigh transpose + quant kernel: https://www.internalfb.com/phabricator/paste/view/P1904683419

input_shape            torch_time_us    triton_time_us    torch_mem_bw_gbps    triton_mem_bw_gbps  triton_speedup
-------------------  ---------------  ----------------  -------------------  --------------------  ----------------
(1, (8192, 5120))            114.976           131.392              1823.99               1596.1   0.88x
(1, (5120, 8192))            145.44            131.456              1441.94               1595.33  1.11x
(16, (8192, 5120))          2182.32           1629.92               1537.56               2058.66  1.34x
(16, (5120, 8192))          2081.39           1745.89               1612.12               1921.91  1.19x
(128, (8192, 5120))        21692.4           23648.6                1237.46               1135.1   0.92x
(128, (5120, 8192))        18088.4           23502.3                1484.02               1142.17  0.77x

…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2769

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 9a7b56a to b3c5f08 Compare August 14, 2025 01:44
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 14, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 14, 2025 05:51
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from b3c5f08 to 02c0707 Compare August 14, 2025 05:51
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/41 August 14, 2025 05:51
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 14, 2025 21:27
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 02c0707 to 601b80b Compare August 14, 2025 21:28
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/41 August 14, 2025 21:28
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 14, 2025 22:23
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 601b80b to 083d476 Compare August 14, 2025 22:23
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/41 August 14, 2025 22:23
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 14, 2025 22:34
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 083d476 to 0edd1de Compare August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/41 August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 14, 2025 23:20
danielvegamyhre added a commit that referenced this pull request Aug 14, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 0edd1de to 2f2f195 Compare August 14, 2025 23:20
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/41 August 14, 2025 23:20
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from 43ffe7a to 24cda99 Compare August 15, 2025 16:21
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 2f2f195 to 046b852 Compare August 15, 2025 16:21
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from 24cda99 to 52ec710 Compare August 15, 2025 16:22
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 046b852 to 7b0bc50 Compare August 15, 2025 16:22
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from 52ec710 to bb57600 Compare August 15, 2025 16:23
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 7b0bc50 to 0ae34d3 Compare August 15, 2025 16:23
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from bb57600 to db9cdc9 Compare August 15, 2025 16:26
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from 0ae34d3 to c4ab846 Compare August 15, 2025 16:26
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from db9cdc9 to c8c7743 Compare August 15, 2025 16:26
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch from c4ab846 to fa6ad0e Compare August 15, 2025 16:27
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/41 branch from c8c7743 to 89b9868 Compare August 15, 2025 16:28
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
…ng scripts

stack-info: PR: #2769, branch: danielvegamyhre/stack/42
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/42 branch 2 times, most recently from f8feef5 to 8b0ba16 Compare August 15, 2025 16:29
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/41 to main August 15, 2025 16:29
@danielvegamyhre danielvegamyhre merged commit 2eae09b into main Aug 15, 2025
8 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants