Support promise style async and use region instead zone #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachue
approved these changes
Mar 5, 2024
COMPLETED: - Add promise style; - Add Retrier for Endpoints or Regions retrying; - Improve all test cases in rs.js, form_up.js, resume_up.js; - Fix multiple bugs. An important is v1 resume upload will not callback if resume from the last part;
- fix an error comment - uncomment some test params for more test cases - ignore ENOENT error when cleanup files after testing
lihsai0
force-pushed
the
refactor/bucket-manager-uploader
branch
from
ceeeb9f to
f9645c8
Compare
bachue
approved these changes
Mar 13, 2024
- return type of deleteBucketEvent - parameter callbackURL of putBucketEvent and updateBucketEvent
- putBucketAccessStyleMode - putBucketMaxAge - putBucketAccessMode - putBucketQuota - getBucketQuota
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 77.62% 87.52% +9.89%
==========================================
Files 27 33 +6
Lines 2159 2180 +21
Branches 455 414 -41
==========================================
+ Hits 1676 1908 +232
+ Misses 483 272 -211
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including #429(rebased)