RB3 gen2: enable more hardware #754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenkooi
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
lumag
reviewed
Feb 17, 2025
lumag
reviewed
Feb 17, 2025
Test jobs for commit 7994e80 |
koenkooi
force-pushed
the
koen/rb3-hw-enablement
branch
from
7994e80 to
3dce8e8
Compare
Test jobs for commit 3dce8e8 |
lumag
approved these changes
Feb 18, 2025
ndechesne
reviewed
Feb 18, 2025
…CHINE_ESSENTIAL_RRECOMMENDS This packagegroup includes the firmware needed to make wifi work and more. Signed-off-by: Koen Kooi <[email protected]>
The modules listed should be common to all, or most, of the machines supported by this BSP. This sets up downstream users of the BSP for success instead of frustration. Signed-off-by: Koen Kooi <[email protected]>
…COMMENDS This lists modules that aren't dragged in by other drivers, determined by looking at the dependents column in `lsmod` output. Signed-off-by: Koen Kooi <[email protected]>
koenkooi
force-pushed
the
koen/rb3-hw-enablement
branch
from
3dce8e8 to
174778f
Compare
lumag
reviewed
Feb 20, 2025
| @@ -11,5 +11,35 @@ KERNEL_DEVICETREE ?= " \ | |||
| " | |||
|
|
|||
| MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \ | |||
| kernel-module-ath11k-ahb \ | |||
| kernel-module-camcc-sc7280 \ | |||
| kernel-module-crct10dif-ce \ | |||
There was a problem hiding this comment.
Do you know, what pulls the CRC module? It doesn't sounds like it should be required on its own.
There was a problem hiding this comment.
lsmod shows nothing:
root@qcs6490-rb3gen2-core-kit:~# lsmod | grep crc
crct10dif_ce 12288 1
The kernel docs show it's being used for SCSI T10, so I suspect the UFS driver autoloads it. I think we can safely drop it from the list, the net effect should only be using a non-SIMD version.
There was a problem hiding this comment.
I think it's not even the UFS:
block/t10-pi.c: return cpu_to_be16(crc_t10dif_update(be16_to_cpu(csum), data, len));
drivers/scsi/lpfc/lpfc_scsi.c: * using crc_t10dif.
drivers/scsi/lpfc/lpfc_scsi.c: crc = crc_t10dif(data, count);
drivers/scsi/scsi_debug.c: csum = cpu_to_be16(crc_t10dif(buf, len));
drivers/target/target_core_sbc.c: crc = crc_t10dif(daddr + offset, avail);
drivers/target/target_core_sbc.c: crc = crc_t10dif_update(crc, daddr, offset);
drivers/target/target_core_sbc.c: crc = crc_t10dif(daddr + dsg_off, avail);
drivers/target/target_core_sbc.c: crc = crc_t10dif_update(crc, daddr, dsg_off);
Test jobs for commit 174778f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The machine configs in meta-qcom don't enable all hardware by default, this PR makes wifi work for core-image-* and enables
pc'asMACHINE_FEATURE.