Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RB3 gen2: enable more hardware #754

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RB3 gen2: enable more hardware #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfcf569
qcs6490-rb3gen-core-kit.conf: add rb3gen2 firmware packagegroup to MA…
koenkooi Feb 17, 2025
1736e14
include/qcom-common: add modules to MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS
koenkooi Feb 18, 2025
174778f
qcs6490-rb3gen2-core-kit: add kernel drivers to MACHINE_ESSENTIAL_RRE…
koenkooi Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions conf/machine/include/qcom-common.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@ PREFERRED_PROVIDER_android-tools-conf = "android-tools-conf-configfs"

PREFERRED_VERSION_linux-yocto ?= "6.12%"

# Add a default set of upstream kernel modules that are needed to make
# the included hardware work in core-image-* derivatives. Since they end
# up as runtime recommendations for the package manager, the build will
# succeed if they are missing, this is behaviour both desired and by
# design.

MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \
kernel-module-fastrpc \
kernel-module-msm \
kernel-module-qcom-stats \
kernel-module-rtc-pm8xxx \
kernel-module-venus-dec \
kernel-module-venus-enc \
"


# Fastboot expects an ext4 image, which needs to be 4096 aligned
IMAGE_FSTYPES ?= "ext4.gz"
IMAGE_ROOTFS_ALIGNMENT ?= "4096"
Expand Down
35 changes: 31 additions & 4 deletions conf/machine/qcs6490-rb3gen2-core-kit.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,35 @@ KERNEL_DEVICETREE ?= " \
"

MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \
linux-firmware-qcom-adreno-a660 \
linux-firmware-qcom-qcm6490-adreno \
linux-firmware-qcom-qcm6490-audio \
linux-firmware-qcom-qcm6490-compute \
kernel-module-ath11k-ahb \
kernel-module-camcc-sc7280 \
kernel-module-crct10dif-ce \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know, what pulls the CRC module? It doesn't sounds like it should be required on its own.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lsmod shows nothing:

root@qcs6490-rb3gen2-core-kit:~# lsmod | grep crc
crct10dif_ce           12288  1

The kernel docs show it's being used for SCSI T10, so I suspect the UFS driver autoloads it. I think we can safely drop it from the list, the net effect should only be using a non-SIMD version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not even the UFS:

block/t10-pi.c: return cpu_to_be16(crc_t10dif_update(be16_to_cpu(csum), data, len));
drivers/scsi/lpfc/lpfc_scsi.c: * using crc_t10dif.
drivers/scsi/lpfc/lpfc_scsi.c:  crc = crc_t10dif(data, count);
drivers/scsi/scsi_debug.c:              csum = cpu_to_be16(crc_t10dif(buf, len));
drivers/target/target_core_sbc.c:                       crc = crc_t10dif(daddr + offset, avail);
drivers/target/target_core_sbc.c:                               crc = crc_t10dif_update(crc, daddr, offset);
drivers/target/target_core_sbc.c:                       crc = crc_t10dif(daddr + dsg_off, avail);
drivers/target/target_core_sbc.c:                               crc = crc_t10dif_update(crc, daddr, dsg_off);

kernel-module-dispcc-sc7280 \
kernel-module-display-connector \
kernel-module-gpucc-sc7280 \
kernel-module-i2c-qcom-geni \
kernel-module-icc-bwmon \
kernel-module-icc-osm-l3 \
kernel-module-lontium-lt9611uxc \
kernel-module-lpassaudiocc-sc7280 \
kernel-module-nb7vpq904m \
kernel-module-nvmem-qcom-spmi-sdam \
kernel-module-nvmem-reboot-mode \
kernel-module-phy-qcom-qmp-combo \
kernel-module-phy-qcom-snps-femto-v \
kernel-module-pinctrl-sc7280-lpass-lpi \
kernel-module-pmic-glink-altmode \
kernel-module-qcom-pd-mapper \
kernel-module-qcom-pon \
kernel-module-qcom-q6v5-pas \
kernel-module-qcom-rng \
kernel-module-qcom-spmi-adc5 \
kernel-module-qcom-spmi-temp-alarm \
kernel-module-qcrypto \
kernel-module-qrtr-smd \
kernel-module-rpmsg-ctrl \
kernel-module-snd-soc-hdmi-codec \
kernel-module-ucsi-glink \
kernel-module-videocc-sc7280 \
packagegroup-firmware-rb3gen2 \
"
Loading