[#922] controlling resources deletion

[aawoznia26]

This closes #922

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

DeletionPolicy was added to Federation, Queue, Shovel, and Vhost resources. It controls whether resource in RabbitMQ cluster is removed when custom resource is deleted.
The deletionPolicy can be set to:

• delete: The resource will be removed from RabbitMQ cluster when the custom resource deleted (default)
• retain: The resource will remain in RabbitMQ cluster when the custom resource deleted

Additional Context

Change is result of issue 922
Corresponding PR in RabbitMQ website repo

[aawoznia26]

Corresponding PR in RabbitMQ website repo

[michaelklishin]

@aawoznia26 thank you. I have asked a few other team members to review this PR.

[Zerpet]

Thank you for the contribution! I like the approach. I left some cosmetic recommendations, but overall I'm happy with the state of this PR.

[aawoznia26]

Thank you @Zerpet for the review. I've applied changes in tests.

[Zerpet]

I'll merge after CI passes. Thank you for this PR!

[aawoznia26]

Hello @Zerpet and @michaelklishin,

Feature PR was merged. How do you suggest to proceed with corresponding change in website, describing new feature here? Last week we reverted PR in website, because it was merged earlier that feature PR.
Should I prepare new PR in website repo right now? Or better to wait until 1.17.0 is released?

[michaelklishin]

@aawoznia26 we need to produce a new release — @Zerpet would be the right person to discuss that — and then revert the commits related to your website PR.

[aawoznia26]

Ok, let's wait for release then. @Zerpet Do you possibly know roughly when new release is planned?

[michaelklishin]

@aawoznia26 I should not speak for other maintainers but it should not take long. Our team decides when it ship it, so why not next week, for example :)

[aawoznia26]

Ok, I will monitor releases then and remember to ask to reapply PR reverted in website repo :)

[Zerpet]

Hey, apologies for the delay in responding back. We are full focus on RabbitMQ 4.1 and its commercial counterpart. There are two PRs that would make sense to squeeze in before cutting a new release #962 #977. I've added those to the 1.17.0 milestone. Given this week is Easter break and next week I'll be out, I'd say tentatively in the first half of May we'll cut a new release.

@aawoznia26 if you don't want to be monitoring our releases, perhaps would be ok to leave the PR as draft to the website? What do you think @michaelklishin ?

[michaelklishin]

@Zerpet the website change was merged and reverted. We need to produce a release, then the revert can be reverted, that's all there is to do.