Add user limits. #962
Merged
Add user limits. #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MirahImage
force-pushed
the
user-limits
branch
5 times, most recently
from
03deb30 to
70e1239
Compare
…operator into user-limits
MirahImage
force-pushed
the
user-limits
branch
2 times, most recently
from
e2e9c07 to
5fcebac
Compare
jaroslaw-bochniak
approved these changes
Apr 14, 2025
Zerpet
reviewed
Apr 15, 2025
There was a problem hiding this comment.
I'm curious about clearing the user limits. It looks like (I haven't tried) if a user limit is set, and then the UserLimits field is set to an empty struct, the declare logic would simply ignore the limits, because the zero value of int32 is 0 and our logic ignores any values equal or below zero.
One option would be to set the UserLimit field as a pointer, so that we can differentiate between the zero value and not set at all (nil). Note that 0 for limits is a valid value in RabbitMQ.
|
@Zerpet it now handles the 0 and negative cases, as well as the change of limits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #960
Summary Of Changes
Adds optional Limits for connections and channels to the user spec.