Skip to content

Add vhost limits. #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 23, 2025
Merged

Add vhost limits. #977

merged 15 commits into from
Apr 23, 2025

Conversation

MirahImage
Copy link
Member

This closes #963

@MirahImage MirahImage requested a review from Zerpet April 8, 2025 11:51
@MirahImage MirahImage marked this pull request as ready for review April 8, 2025 12:58
@MirahImage MirahImage requested a review from mkuratczyk April 14, 2025 16:27
@Zerpet Zerpet added this to the v1.17.0 milestone Apr 15, 2025
@Zerpet Zerpet mentioned this pull request Apr 15, 2025
Merged
Zerpet
Zerpet reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about clearing the vHost limits. The field in the spec is a pointer, so perhaps we could clear the limits if the field is nil ?

As the code stands, once a value is set, it can be lifted by setting to a negative value, but it can't be cleared.

@MirahImage
Copy link
Member Author

Vhost limits can now be updated.

@MirahImage MirahImage merged commit d4eb0b1 into main Apr 23, 2025
8 checks passed
@MirahImage MirahImage deleted the vhost-limits branch April 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet left review comments

@jaroslaw-bochniak jaroslaw-bochniak jaroslaw-bochniak approved these changes

@mkuratczyk mkuratczyk Awaiting requested review from mkuratczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

Add vhost limits
3 participants
@MirahImage @Zerpet @jaroslaw-bochniak