Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix craches where session pgid is unknown #330 #504

Closed
wants to merge 2 commits into from

Conversation

oklas
Copy link

@oklas oklas commented Dec 26, 2016

This changes make it possible to work on some os.
It contains only pgid result checking and catch exceptions if any.

(more about problem in discussion #330)

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@oklas
Copy link
Author

oklas commented Apr 9, 2017

@rafaelfranca this does not broke tests and does not add new feature - this is only fix. Can you please comment or request anything to step to merge?

@oklas
Copy link
Author

oklas commented Dec 30, 2017

Happy new year!

@oklas
Copy link
Author

oklas commented Feb 6, 2020

Hi @rafaelfranca

This changes actually contains only checking and catch exceptions to make it worked on some os.

Could you review and merge?

@rafaelfranca
Copy link
Member

Can you confirm this is still a problem with newest release of spring?

@oklas
Copy link
Author

oklas commented Dec 8, 2021

I can not even confirm problem with one of previous release 2.1.0 - seems it is worked (it can start and stop without crash). It is strange but I think there is no sense to spend time to inspect. The problem was on Freebsd partially because ps does not support -o sess=. Current version seems does not use such ps output. But I notice another minor problem and submit it here #660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants