Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix craches where session pgid is unknown #330 #504

Closed
wants to merge 2 commits into from
Closed

fix craches where session pgid is unknown #330 #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8bb5c7
fix craches where session pgid is unknown #330
oklas Dec 26, 2016
1e5cf62
fix(sid): rename ps column sid back to sess
oklas Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/spring/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ def rails_env_for(args, default_rails_env)
# This will cause it to be automatically killed once the session
# ends (i.e. when the user closes their terminal).
def set_pgid
Process.setpgid(0, SID.pgid)
pgid = SID.pgid
if pgid.nil?
log "warn: unable to fetch process group of current session"
return
end
Process.setpgid(0, pgid)
end

# Ignore SIGINT and SIGQUIT otherwise the user typing ^C or ^\ on the command line
Expand Down
7 changes: 5 additions & 2 deletions lib/spring/sid.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ def self.sid
end

def self.pgid
Process.getpgid(sid)
end
begin
Process.getpgid(sid)
rescue
end
end
end
end