Implement Network Configurators (nmc, nmstate, nmconnections) #819
Conversation
github-actions
bot
added
area/operator
There was a problem hiding this comment.
Patch looks good... anyway, why not support both nmc and nmstate?
The library behind it is the same, ti changes "just" the binary and the syntax, changes to the code could be minimal.
This would open to wider usage in community images where nmstate could be already be available or packaged for some base OS images, while supporting also the nmc binary where nmstate is not available (or nmc is preferred).
The idea could be to have a kind of "autodetection" just probing for the nmc binary first.
How would that look?
pkg/network/network.go
Outdated
| @@ -31,7 +31,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| nmstateTempPath = "/tmp/elemental-nmstate.yaml" | |||
| nmcDesiredStatesDir = "/tmp/desired-states" | |||
| nmcNewtorkConfigDir = "/tmp/network-config" | |||
There was a problem hiding this comment.
nit: would consider grouping nmc dirs under a common /tmp/something dir (e.g., "/tmp/nmc/desired-states", "/tmp/nmc/network-config")
Could be an idea, but I would avoid any autodetection for simplicity. |
anmazzotti
force-pushed
the
nm_configurator_support
branch
from
0ab1172 to
4ec49a0
Compare
|
@fgiudici I added I'd also like to install both nmc and nmstate in the dev image, so that we can locally test with both and for example have three flavors of sample registrations. Documentation should also be updated accordingly (so most likely one subpage for each configurator, with a few examples) I'll work on that if you are ok with this solution |
anmazzotti
changed the title
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
nm_configurator_support
branch
from
5295343 to
8dda728
Compare
No description provided.