Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] apply resource logger to ray cluster test #3075

Merged

Conversation

simotw
Copy link
Contributor

@simotw simotw commented Feb 19, 2025

Why are these changes needed?

Print related resources when a cluster test failed.

Easier to debug.

Related issue number

Related PR

This PR depends on
#3070
Please review based on the last commit [CI] apply resource logger to ray cluster test.

Screen shots

CleanShot 2025-02-19 at 11 43 25@2x

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@simotw simotw force-pushed the ci/apply-error-logger-to-raycluster-test branch from 26188e8 to ff4295d Compare February 19, 2025 03:46
@simotw simotw force-pushed the ci/apply-error-logger-to-raycluster-test branch from ff4295d to 6260d37 Compare February 19, 2025 06:06
@simotw simotw marked this pull request as ready for review February 19, 2025 06:21
@kevin85421
Copy link
Member

would you mind resolving the conflicts? Thanks

@simotw simotw force-pushed the ci/apply-error-logger-to-raycluster-test branch from 6260d37 to 72d4a55 Compare February 20, 2025 03:43
@simotw
Copy link
Contributor Author

simotw commented Feb 20, 2025

would you mind resolving the conflicts? Thanks

Hi @kevin85421 , I have rebased the pr with latest master. Thank you!

@kevin85421 kevin85421 merged commit a9aa9a3 into ray-project:master Feb 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants