razzmatazz · razzmatazz · Apr 27, 2025 · Feb 11, 2025 · Apr 3, 2025 · Apr 4, 2025
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-24.04]
-        dotnet: [8.0.404]
+        dotnet: [9.0.x]
     runs-on: ${{ matrix.os }}
 
     steps:

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest, ubuntu-24.04]
-        dotnet: [8.0.404]
+        dotnet: [9.0.x]
       fail-fast: false
 
     runs-on: ${{ matrix.os }}

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
+* csharp-ls will now use and require .NET 8 runtime/SDK
+  - PR by @lapponiandevil in https://github.com/razzmatazz/csharp-language-server/pull/222
 * Upgrade Ionide.LanguageServerProtocol to 0.7.0:
   - https://github.com/razzmatazz/csharp-language-server/pull/221
 * Reduce startup notifications by using "window/logMessage"

diff --git a/global.json b/global.json
@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.400",
+    "version": "9.0.1",
     "rollForward": "minor"
   }
 }
diff --git a/src/CSharpLanguageServer/CSharpLanguageServer.fsproj b/src/CSharpLanguageServer/CSharpLanguageServer.fsproj
@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Description>C# LSP language server</Description>
     <PackAsTool>true</PackAsTool>
     <ToolCommandName>csharp-ls</ToolCommandName>

diff --git a/src/CSharpLanguageServer/Handlers/Workspace.fs b/src/CSharpLanguageServer/Handlers/Workspace.fs
@@ -82,11 +82,11 @@ module Workspace =
             match Path.GetExtension(change.Uri) with
             | ".csproj" ->
                 do! context.WindowShowMessage "change to .csproj detected, will reload solution"
-                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5)))
+                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5:int64)))
 
             | ".sln" ->
                 do! context.WindowShowMessage "change to .sln detected, will reload solution"
-                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5)))
+                context.Emit(SolutionReloadRequest (TimeSpan.FromSeconds(5:int64)))
 
             | ".cs" ->
                 match change.Type with

diff --git a/tests/CSharpLanguageServer.Tests/CSharpLanguageServer.Tests.fsproj b/tests/CSharpLanguageServer.Tests/CSharpLanguageServer.Tests.fsproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
 
     <IsPackable>false</IsPackable>
     <GenerateProgramFile>false</GenerateProgramFile>

diff --git a/tests/CSharpLanguageServer.Tests/ReferenceTests.fs b/tests/CSharpLanguageServer.Tests/ReferenceTests.fs
@@ -5,10 +5,10 @@ open Ionide.LanguageServerProtocol.Types
 
 open CSharpLanguageServer.Tests.Tooling
 
-[<TestCase>]
-let testReferenceWorks() =
-    use client = setupServerClient defaultClientProfile
-                                   "TestData/testReferenceWorks"
+[<TestCase("TestData/dotnet9TestReferenceWorks")>]
+[<TestCase("TestData/dotnet8TestReferenceWorks")>]
+let testReferenceWorks(testDataDir: string) =
+    use client = setupServerClient defaultClientProfile testDataDir
     client.StartAndWaitForSolutionLoad()
 
     use classFile = client.Open("Project/Class.cs")

diff --git a/...tData/testReferenceWorks/Project/Class.cs → ...otnet8TestReferenceWorks/Project/Class.cs b/...tData/testReferenceWorks/Project/Class.cs → ...otnet8TestReferenceWorks/Project/Class.cs
diff --git a/...testReferenceWorks/Project/Project.csproj → ...TestReferenceWorks/Project/Project.csproj b/...testReferenceWorks/Project/Project.csproj → ...TestReferenceWorks/Project/Project.csproj
diff --git a/tests/CSharpLanguageServer.Tests/TestData/dotnet9TestReferenceWorks/Project/Class.cs b/tests/CSharpLanguageServer.Tests/TestData/dotnet9TestReferenceWorks/Project/Class.cs
@@ -0,0 +1,11 @@
+class Class
+{
+    public void MethodA(string arg)
+    {
+    }
+
+    public void MethodB(string arg)
+    {
+        MethodA(arg);
+    }
+}
diff --git a/tests/CSharpLanguageServer.Tests/TestData/dotnet9TestReferenceWorks/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/dotnet9TestReferenceWorks/Project/Project.csproj
@@ -0,0 +1,6 @@
+<Project Sdk="Microsoft.NET.Sdk">
+    <PropertyGroup>
+        <OutputType>Exe</OutputType>
+        <TargetFramework>net9.0</TargetFramework>
+    </PropertyGroup>
+</Project>
diff --git a/...SharpLanguageServer.Tests/TestData/testCodeActionOnMethodNameWorks/Project/Project.csproj b/...SharpLanguageServer.Tests/TestData/testCodeActionOnMethodNameWorks/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/tests/CSharpLanguageServer.Tests/TestData/testDefinitionWorks/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/testDefinitionWorks/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/...rpLanguageServer.Tests/TestData/testDefinitionWorksInAspNetProject/Project/Project.csproj b/...rpLanguageServer.Tests/TestData/testDefinitionWorksInAspNetProject/Project/Project.csproj
@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="8.0.11" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="9.0.1" />
   </ItemGroup>
 </Project>
diff --git a/tests/CSharpLanguageServer.Tests/TestData/testEditorConfigFormatting/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/testEditorConfigFormatting/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/tests/CSharpLanguageServer.Tests/TestData/testHoverWorks/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/testHoverWorks/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/tests/CSharpLanguageServer.Tests/TestData/testPullDiagnosticsWork/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/testPullDiagnosticsWork/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/tests/CSharpLanguageServer.Tests/TestData/testPushDiagnosticsWork/Project/Project.csproj b/tests/CSharpLanguageServer.Tests/TestData/testPushDiagnosticsWork/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>
diff --git a/....Tests/TestData/testReferenceWorksToAspNetRazorPageReferencedValue/Project/Project.csproj b/....Tests/TestData/testReferenceWorksToAspNetRazorPageReferencedValue/Project/Project.csproj
@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="8.0.11" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="9.0.1" />
   </ItemGroup>
 </Project>
diff --git a/...Server.Tests/TestData/testServerRegistersCapabilitiesWithTheClient/Project/Project.csproj b/...Server.Tests/TestData/testServerRegistersCapabilitiesWithTheClient/Project/Project.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
     </PropertyGroup>
 </Project>