Skip to content

.NET 9 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2025
Merged

.NET 9 #222

merged 6 commits into from
Apr 27, 2025

Conversation

lapponiandevil
Copy link
Contributor

@lapponiandevil lapponiandevil commented Mar 14, 2025

What are your thoughts on .NET 9 support?

This compiles and "works on my machine" (MacOS 15.3, Neovim + LazyVim), but hasn't been battle tested that much.

@razzmatazz
Copy link
Owner

This bumps runtime requirement but does not add any features, correct?
Might be a good thing to get this in as .net has been release some time ago already..

@razzmatazz
Copy link
Owner

and thank you, @lapponiandevil !

@lapponiandevil
Copy link
Contributor Author

lapponiandevil commented Mar 18, 2025

This bumps runtime requirement but does not add any features, correct? Might be a good thing to get this in as .net has been release some time ago already..

Yes, that is correct.

I haven't verified all functionality though, as my general LSP knowledge is very limited. This was a "quick and dirty" fix to make stuff work for me. So far It has been working fine.

@Decodetalkers
Copy link
Contributor

Decodetalkers commented Apr 3, 2025

You need also change the yaml of workflow, that will make the ci fine

@lapponiandevil
Copy link
Contributor Author

Let's see if that did it.

@thedeany
Copy link

What is the status of this PR? Is .NET 9 support close to being merged?

@lapponiandevil
Copy link
Contributor Author

As a first step, the workflow could be triggered again.
My previous attempts on getting the SDK version right should be fixed now. The version might still need single quotes though?
Let me know if you want me to add that before triggering the workflow @razzmatazz.

@razzmatazz
Copy link
Owner

testReferenceWorksToAspNetRazorPageReferencedValue appears to be flaky, let me rebase this on main where this particular test is marked with [Ignore]

@razzmatazz razzmatazz merged commit 8e390fd into razzmatazz:main Apr 27, 2025
2 checks passed
@razzmatazz
Copy link
Owner

0.17.0 has been released with changesets from this PR merged in: https://www.nuget.org/packages/csharp-ls/0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants