RDKEMW-19048: Add vault_processor_release C wrapper to clientlibraries r4.4#4172
Open
sergiygladkyy wants to merge 1 commit into
Open
RDKEMW-19048: Add vault_processor_release C wrapper to clientlibraries r4.4#4172sergiygladkyy wants to merge 1 commit into
sergiygladkyy wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports an earlier change onto the develop branch to expose Implementation::Vault::ProcessorRelease() via a C ABI wrapper (vault_processor_release()), enabling external components (e.g., CryptographyExtAccess) to explicitly release the SecProcessor handle on deep-sleep entry.
Changes:
- Adds a new patch that introduces
vault_processor_release()inside the cryptography SecApiVault.cppC ABI section. - Updates the
wpeframework-clientlibraries_4.4.bbrecipe to apply the new patch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipes-extended/wpe-framework/wpeframework-clientlibraries/r4.4/0002-RDKEMW-18043-Add-vault_processor_release-C-wrapper.patch | Adds the C ABI wrapper function for releasing the Vault SecProcessor handle. |
| recipes-extended/wpe-framework/wpeframework-clientlibraries_4.4.bb | Includes the new patch in SRC_URI for the 4.4 clientlibraries build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+31
| + void vault_processor_release(void) | ||
| + { | ||
| + VaultImplementation* impl = vault_instance(CRYPTOGRAPHY_VAULT_DEFAULT); | ||
| + if (impl != nullptr) { | ||
| + reinterpret_cast<Implementation::Vault*>(impl)->ProcessorRelease(); | ||
| + } |
Comment on lines
28
to
33
| file://0001-error-handling-if-invalid-external-input.patch \ | ||
| file://r4.4/0001-Implement-IPersistent-interface-for-RPC-Vault.patch \ | ||
| file://r4.4/0001-SecAPI-Re-acquire-sec-handle-after-flush.patch \ | ||
| file://r4.4/0002-RDKEMW-18043-Add-vault_processor_release-C-wrapper.patch \ | ||
| file://r4.4/0001-DELIA-64727-Prealloc-secure-memory-before-decrypt.patch \ | ||
| file://r4.4/0001-RDKEMW-7064-Dont-decrypt-fake-buffer-is-revoke-has-b.patch \ |
This was referenced May 22, 2026
sergiygladkyy
force-pushed
the
feature/RDKEMW-19048-cryptography-deep-sleep
branch
from
491b282 to
0f2e2f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Develop-branch port of RDKEMW-18043 (support/8.5.3.0).
RDKEMW-19048 tracks the develop-branch sibling per RM's one-ticket-per-branch policy.
Adds bbappend patch
0002-RDKEMW-18043-Add-vault_processor_release-C-wrapper.patchtowpeframework-clientlibraries_4.4.bb. The patch exposesImplementation::Vault::ProcessorRelease()via C ABI asvault_processor_release(), so the CryptographyExtAccess plugin can release the SecProcessor handle on deep-sleep entry (paired with entservices-cryptography PR #10 which adds the call site).Test plan
T vault_processor_releaseU vault_processor_release