Skip to content

Rebase to develop#211

Open
Sonajeya31 wants to merge 345 commits into
rdkemw-1993-bothfrom
develop
Open

Rebase to develop#211
Sonajeya31 wants to merge 345 commits into
rdkemw-1993-bothfrom
develop

Conversation

@Sonajeya31
Copy link
Copy Markdown
Contributor

No description provided.

@Sonajeya31 Sonajeya31 requested review from a team as code owners August 11, 2025 09:12
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 11, 2025

CLA assistant check
All committers have signed the CLA.

ssitar583 and others added 27 commits November 11, 2025 22:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CMFSUPPORT-3454 Banana Pi changes required for meta-rdk
* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

* Update bblayers.conf.sample

---------

Co-authored-by: madanagopalt <madanagopal123@gmail.com>
Signed-off-by: Arjun <arjun_daasuramdass@comcast.com>
RDKEMW-10241:Add new meta-layer for appmanagers (#341)
RDK-59966 : Bring the required changes to build RDKB stack
Reason for change:

Update rdkb.inc with all broadband related variables
Update rdk.conf to remove unused setting which is causing failure in broadband
Update the components to build RDKB without disturbing client profiles
Update setup-environment to support poky
Update bblayers.conf.sample to support poky and RDKB layers
Update webconfig-framework to include the changes required for RDKB.
Update cimplog for RDKB requirement Note: rdkb.inc should be reviewed and cleaned up properly after all the required layers are migrated.
Bring in required recipes for RDKB to build which are not OE components.
Changes are mostly for broadband without affecting the current client profiles.
* Add GitHub issue template with DoD checklist

- Added middleware_change_request.yml issue template
- Includes Definition of Done checklist with Status as first column
- Status options: Not Started, Done, Not Applicable
- Supports multiline items using <br> tags
- Tracks middleware component changes, dependencies, and layer tags

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add GitHub issue template with DoD checklist

- Added middleware_change_request.yml issue template
- Includes Definition of Done checklist with Status as first column
- Status options: Not Started, Done, Not Applicable
- Supports multiline items using <br> tags
- Tracks middleware component changes, dependencies, and layer tags

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/middleware_change_request.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Simplify status dropdown in middleware change request template

- Remove 'Not Started' text from status column
- Replace with simple Yes/No/NA options
- Remove status options legend for cleaner UI

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Replace dropdown status fields with checkbox format
- Combine status selection and details into paired fields
- Make all fields optional for better user experience
- Improve placeholder text for clarity
* Simplify status fields in middleware change request template

- Replace dropdown status fields with checkbox format
- Combine status selection and details into paired fields
- Make all fields optional for better user experience
- Improve placeholder text for clarity

* Further simplify checkbox labels in middleware template

- Move DoD item descriptions directly into checkbox labels
- Remove redundant label fields for cleaner format
- Create more intuitive checklist-style interface
* Simplify status fields in middleware change request template

- Replace dropdown status fields with checkbox format
- Combine status selection and details into paired fields
- Make all fields optional for better user experience
- Improve placeholder text for clarity

* Further simplify checkbox labels in middleware template

- Move DoD item descriptions directly into checkbox labels
- Remove redundant label fields for cleaner format
- Create more intuitive checklist-style interface

* Remove field labels for cleaner form appearance

- Add empty label fields to checkboxes and inputs
- Creates minimal, streamlined form interface
- Checkbox labels and placeholders provide all necessary context
Copilot AI review requested due to automatic review settings April 29, 2026 09:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 116 out of 116 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 116 out of 116 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +18 to +20
#include <linux/input.h>
+#include <dlfcn.h>`

Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch introduces a stray trailing backtick after the include, which will cause compilation to fail when the patch is applied.

Copilot uses AI. Check for mistakes.
Comment on lines +27 to +31
do_install:append () {
install -d ${D}${systemd_unitdir}/system
rm -rf ${S}/process-monitor.service
install -m 0644 ${WORKDIR}/process-monitor.service ${D}${systemd_unitdir}/system
install -m 0644 ${WORKDIR}/process-monitor.path ${D}${systemd_unitdir}/system
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing files from the source tree during do_install (rm -rf ${S}/process-monitor.service) is brittle and can break incremental builds or debugging. If the goal is to avoid installing the upstream unit file, prefer overriding/patching the install step or removing the file from ${D} after install instead of mutating ${S}.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 116 out of 116 changed files in this pull request and generated 4 comments.

Comment on lines 7 to 11

DEPENDS = "dbus ${BLUEZ} rdk-logger"
DEPENDS = "dbus ${BLUEZ} rdk-logger telemetry"
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
DEPENDS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'gdbus_bluez5', 'glib-2.0-native', '', d)}"

Comment on lines +20 to +36
# Define valid ticket IDs
VALID_TICKET_IDS=("RDKEMW" "RDKEVD" "IMMUI" "RDK" "RDKMVE" "RDKDEV")

# Function to validate ticket format and ID(s)
validate_ticket() {
local text="$1"
local field_name="$2"

echo "Validating $field_name: $text"

# Check if text matches the pattern <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <desc>
if [[ ! "$text" =~ ^([A-Z0-9]+-[0-9]+)([[:space:]]*,[[:space:]]*[A-Z0-9]+-[0-9]+)*[[:space:]]*:[[:space:]]*.+ ]]; then
echo "ERROR: $field_name format is invalid."
echo "Expected format: <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <description>"
echo "Example (single): RDKEMW-123 : Fix playbook issue"
echo "Example (multiple): RDKEMW-123, RDKDEV-45 : Fix playbook issue"
echo ""
Comment on lines +18 to +23
EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release"

# SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96"
SRCREV = "${AUTOREV}"
PV = "1.0.0"
PR = "r0"
Comment on lines +3 to +6
LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/Apache-2.0;md5=89aea4e17d99a7cacdbeed46a0096b10"

SRCREV = "${AUTOREV}"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 116 out of 116 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 115 out of 115 changed files in this pull request and generated 2 comments.

Comment on lines +9 to +21
# SRC_URI = "git://github.com/TeknoVenus/ProcessMonitor.git;branch=main"
SRC_URI = "git://github.com/gomathishankar37/ProcessMonitor.git;protocol=https;branch=exit-handler"

SRC_URI:append = " file://process-monitor.path \
file://process-monitor.service \
"

inherit cmake systemd

EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release"

# SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96"
SRCREV = "${AUTOREV}"
Comment on lines +462 to +466
+ struct timeval rcv_timeout = {
+ .tv_sec = SERVICE_MODE_SOCKET_TIMEOUT_MS/1000,
+ .tv_usec = (SERVICE_MODE_SELECT_TIMEOUT_MS%1000)*1000
+ };
+ setsockopt(cd, SOL_SOCKET, SO_RCVTIMEO, &rcv_timeout, sizeof(rcv_timeout));
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 115 out of 115 changed files in this pull request and generated 3 comments.

EXTRA_OECONF:append = " --enable-iarmbusSupport=yes"
EXTRA_OECONF:append = " --enable-iarmbusSupport=yes --enable-t2api=yes"

EXTRA_OEMAKE += "LIBS='-lsafec'"
EXTRA_OECONF:append = " --enable-iarmbus=yes --enable-tr69hostif=yes"
EXTRA_OECONF:append:client = " --enable-iarmbus=yes --enable-tr69hostif=yes"
EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes"
EXTRA_OEMAKE += "LIBS='-lsafec'"

RDEPENDS:${PN} += "systimemgrfactory"

EXTRA_OECONF = "--enable-t2api=yes"
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 118 out of 118 changed files in this pull request and generated 4 comments.

Comment on lines +8 to 10
DEPENDS = "dbus ${BLUEZ} rdk-logger telemetry"
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
DEPENDS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'gdbus_bluez5', 'glib-2.0-native', '', d)}"
Comment on lines +18 to +24
"name": "test",
"enabled": true,
"status": "Up",
"InitialRunLevel": 5,
"CurrentRunLevel": 5,
"id": 2,
"packager": "local-tarball"
Comment on lines +19 to +23

# SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96"
SRCREV = "${AUTOREV}"
PV = "1.0.0"
PR = "r0"
Comment on lines +65 to +67
#Do only for brodband
if [ "$DEVICE_TYPE" = "broadband" ];then
log_info "Creating destination directory: $(dirname "$DST_BIN")"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.