-
Notifications
You must be signed in to change notification settings - Fork 18
Rebase to develop #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rdkemw-1993-both
Are you sure you want to change the base?
Rebase to develop #211
Changes from all commits
08cc1b0
668d81b
0987328
fba2890
ed16b2e
1f93dff
332c42d
1931ada
27a08ab
20813d2
b3cd036
f21a254
72b2cef
c10e24e
55b0578
9bfeae1
63b2e6b
327e893
5714b35
f302c98
2ae5139
75b0a4a
aae4a96
9a23925
08d9e73
07b5acc
0011f78
ea0d85c
6b7cb30
7876b75
9ce4835
99a8a77
b3ff912
1d5ed1d
6a645e1
85e423f
3cdd1de
77b249d
5170abb
2819a33
10fb0f0
35a25dd
99f7d62
595555b
bcc0dae
17fc538
68aafa7
f8c3c55
db05fe2
d765e20
0e8569d
c7fce5a
7fef63d
d6c1ba3
df0873a
df1e216
8ff2296
57bf982
67cf187
efcd7d3
0cb4d7c
165707e
450df3b
bb60c3a
2df7308
815741c
bd48685
146a690
05077ef
8c05c22
f00828a
974c378
7e69238
a0ac976
2528ca4
d25c2c5
1f8842f
65d2dcf
1fb98a6
db7c6c6
f88bb07
e9c0ee7
9db063f
b050da5
71ac0e1
9f34139
6762dd8
46576c9
2815d58
39837aa
a252eba
2488575
ee67c6c
67a7b04
a83918a
cfad84d
a91a9b5
154ecae
af210ef
74b7827
1639f55
802d3fb
a1b4e6c
7693d32
f6a5e8a
c04edd7
ceca4aa
fddf930
b40bf74
3791201
62855d4
f05aff3
8509e84
31a5c8d
93a34ad
95361b3
d1a10e8
1ba2ee6
4e4daf5
b45401a
caba7b8
10d3a10
e2e1175
b0e80be
0e47862
0223e6a
af2d087
c86a0bf
11c8d3a
ff3f6e2
2a72aa2
4197a4f
6c407f0
2a49dfa
41693ac
286cde9
9e8b55a
a5d1b44
6d8beb7
a265f45
d0b464b
68bb3c1
a3ccefa
a33be56
375a5ee
8c63bf0
936c2a8
5e0de54
6abf7cc
dd6b47c
8f4c53f
e11a4df
3419271
1cab18f
09d6178
48c349b
41d0d0e
885a8d0
2f21ed1
44574e0
e50b390
82d5670
3bd9f33
ac6ee43
ef60b0a
da178c1
99ab48b
d106244
89fe715
3b5eaa5
7c1d1d6
5b310d5
a131fb4
e04143f
d8fc05c
5c4d834
8491a77
fd23bd3
a6b4a60
ccc00dd
18c20db
48e9c73
4563e40
c8c44ae
0f48555
428f2cf
8d13814
143f4fb
a2462d8
4e1ad50
b765121
cdba83c
bc3ed17
6c27885
289ad33
2b6022e
efef0e6
83611a0
54fd60d
c9f543c
cfc2f2d
60f15c8
9ce634f
c1587e6
1dba172
3739f4e
7b31d41
2273ab9
e3c4dc5
b93cbef
9284c3c
46d43d7
523d7dc
0133066
d84ce71
76b016b
6535b0a
9f49fe7
4a1db3a
b36307f
ece5db5
eb5c8ca
4683ca8
f382849
fd5c4b1
ce28ab1
0c562e0
f313198
ec582c2
6c0ddbf
22cefb7
9481341
defc5f1
6ca7ead
077f386
cf47102
a671f7a
1676837
1902976
6a339b0
6076755
937f883
51cf349
1d01dbc
cd15c07
da7cc42
5e792f9
3cd27d4
cc860f0
2fcdd6d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| name: RDK-E Middleware Change Request | ||
| description: Change Request for RDK-E Middleware | ||
| title: "<JIRA TICKET>:<Ticket Title> " | ||
| labels: ["MW Change Request"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Change Request for RDK-E Middleware | ||
|
|
||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Description | ||
| description: Provide a clear and concise description of the feature or bug ticket | ||
| placeholder: Describe the changes you are bringing | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: additional-context | ||
| attributes: | ||
| label: Additional Context | ||
| description: Add any other context, screenshots, or examples about the feature request | ||
| placeholder: Any other relevant information | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| id: dod-checklist | ||
| attributes: | ||
| label: Definition of Done (DoD) | ||
| description: Mark items with [x] and replace the placeholder text on Details lines with actual information. | ||
| value: | | ||
| Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged. | ||
|
|
||
| **IMPORTANT:** Do NOT provide any proprietary information including: | ||
| - Links to internal Automatics/CI builds | ||
| - Links to internal Confluence pages | ||
| - Any other Comcast/Sky proprietary or confidential information | ||
| - Development Build/Setup Details | ||
|
|
||
| Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket. | ||
|
|
||
| --- | ||
|
|
||
| - [ ] **Middleware component tags with changelog** | ||
| - Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work. | ||
|
|
||
| - [ ] **Tested on STBs** | ||
|
|
||
| - [ ] **Tested on TVs** | ||
|
|
||
| - [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)** | ||
| - Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md) | ||
|
|
||
| - [ ] **Do Widgets Need Publishing** | ||
| - Details: (Provide context if widgets are involved) | ||
|
|
||
| - [ ] **Copilot review for Components** | ||
| - Details: (Any comments on the review) | ||
|
|
||
| - [ ] **Component Test** | ||
| - Details: Share Testing done as part of components release | ||
|
|
||
| - [ ] **Integration Testing** | ||
| - Details: Provide details on Integration testing done within Middleware layer | ||
|
|
||
| - [ ] **E2E Testing** | ||
| - Details: Provide details on end to end testing done across all layers | ||
|
|
||
| - [ ] **Performance Testing** | ||
| - Details: Provide details on performance testing done | ||
|
|
||
| - [ ] **Static code analysis/Coverity** | ||
| - Details: Share Coverity runs for components affected | ||
|
|
||
| - [ ] **Manual Functional Test** | ||
|
|
||
| validations: | ||
| required: true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Auto PR Creation Caller - Broadband Community | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
| branches: | ||
| - develop | ||
| - support/dunfell | ||
| - 'support/*.*.*' | ||
|
|
||
| jobs: | ||
| call_auto_pr_workflow: | ||
| if: github.event.pull_request.merged == true | ||
| uses: rdkcentral/build_tools_workflows/.github/workflows/auto_pr_creation_rdkb_manifest.yml@develop | ||
| secrets: | ||
| RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: "CLA" | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| actions: write | ||
| statuses: write | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_target: | ||
| types: [opened, closed, synchronize] | ||
|
|
||
| jobs: | ||
| CLA-Lite: | ||
| name: "Signature" | ||
| uses: rdkcentral/cmf-actions/.github/workflows/cla.yml@v1 | ||
| secrets: | ||
| PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ASSISTANT }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Fossid Stateless Diff Scan | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| call-fossid-workflow: | ||
| if: ${{ ! github.event.pull_request.head.repo.fork }} | ||
| uses: rdkcentral/build_tools_workflows/.github/workflows/fossid_integration_stateless_diffscan.yml@1.0.0 | ||
| secrets: | ||
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | ||
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | ||
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | ||
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,126 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| name: PR Title Validation | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| pull_request: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| branches: [develop] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| types: [opened, edited, synchronize] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+6
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+8
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| validate-pr-title: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Checkout code | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Validate PR Title | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| PR_BODY: ${{ github.event.pull_request.body }} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Define valid ticket IDs | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| VALID_TICKET_IDS=("RDKEMW" "RDKEVD" "IMMUI" "RDK" "RDKMVE" "RDKDEV") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Function to validate ticket format and ID(s) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| validate_ticket() { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| local text="$1" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| local field_name="$2" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| echo "Validating $field_name: $text" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Allow explicit exceptions for maintenance PR titles (e.g., rebases/merges) | |
| if [ "$field_name" = "PR title" ]; then | |
| if [[ "$text" =~ ^Rebase[[:space:]]+to[[:space:]]+develop$ ]] || [[ "$text" =~ ^Merge[[:space:]].* ]]; then | |
| echo "$field_name recognized as maintenance (rebase/merge); skipping ticket ID validation." | |
| return 0 | |
| fi | |
| fi | |
Copilot
AI
Feb 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow enforces a strict <TICKET>-<N> : <desc> format for all PR titles to develop, which will fail legitimate maintenance PRs like pure rebases/merges (e.g., the current PR title). Consider allowing an explicit exception pattern (e.g., ^Rebase to develop$ / ^Merge .*), or skipping validation for PRs labeled as rebase/maintenance to avoid blocking required branch hygiene.
| # Validate PR Title (always required) | |
| echo "=== Validating PR Title ===" | |
| if ! validate_ticket "$PR_TITLE" "PR title"; then | |
| echo "" | |
| echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list: ${VALID_TICKET_IDS[@]}" | |
| exit 1 | |
| fi | |
| echo "" | |
| echo "=== PR Title Validation PASSED ===" | |
| echo "Ticket ID found in PR title." | |
| echo "" | |
| echo "ALL VALIDATIONS PASSED! PR title contains a valid ticket ID." | |
| # Validate PR Title (allow explicit maintenance titles without ticket IDs) | |
| # Maintenance PRs like pure rebases or merges (e.g., "Rebase to develop", "Merge release/x into develop") | |
| # are allowed to bypass strict ticket ID validation. | |
| if [[ "$PR_TITLE" =~ ^Rebase[[:space:]]+to[[:space:]]+develop$ || "$PR_TITLE" =~ ^Merge[[:space:]].* ]]; then | |
| echo "PR title '$PR_TITLE' matches a maintenance pattern; skipping ticket ID validation." | |
| else | |
| echo "=== Validating PR Title ===" | |
| if ! validate_ticket "$PR_TITLE" "PR title"; then | |
| echo "" | |
| echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list: ${VALID_TICKET_IDS[@]}" | |
| exit 1 | |
| fi | |
| echo "" | |
| echo "=== PR Title Validation PASSED ===" | |
| echo "Ticket ID found in PR title." | |
| echo "" | |
| echo "ALL VALIDATIONS PASSED! PR title contains a valid ticket ID." | |
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow will fail PRs whose titles don’t match
<TICKET>-<N> : <desc>. Given this PR is titled "Rebase to develop", it will be blocked. If rebases/merges are expected, add an explicit allowlist (e.g.,^Rebase( to develop)?$) or make the check conditional (label-based or skip on maintainers).