Add AppName warning visibility state#112
Merged
pvinis merged 2 commits intoreact-native-community:masterfrom Dec 30, 2019
Merged
Add AppName warning visibility state#112pvinis merged 2 commits intoreact-native-community:masterfrom
pvinis merged 2 commits intoreact-native-community:masterfrom
Conversation
…into feat/appNameWarning
pvinis
approved these changes
Dec 30, 2019
Member
pvinis
left a comment
pvinis
left a comment
There was a problem hiding this comment.
Thanks, my web UI skills are not great, thanks for making it actually looking nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've added a state to determine weather to display warning about AppName or not, as suggested in #111 (comment)
Warning will be displayed when user presses
Show me how to upgrade!, and it's closable upon user's choice.Test Plan
What are the steps to reproduce?
Checklist