Add Manage GH App dialog in connected accounts #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel like this is an obvious place people will look for this, so we should make it more visible there?
ericholscher
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Oct 8, 2025
Needed for readthedocs/ext-theme#655, which otherwise I need to override the Allauth views for, and this seems useful in other places if we want to keep linking it.
agjohnson
reviewed
Oct 8, 2025
| <a href="https://github.com/apps/{{ GITHUB_APP_NAME }}/installations/new/" | ||
| target="_blank"> | ||
| <div class="ui button green">{% trans "Manage GitHub App" %}</div> | ||
| </a> |
There was a problem hiding this comment.
Buttons like this shouldn't be added to this section. The top button on a listing view is strictly for adding an item to the listing.
The standard pattern we're following is this should be an icon button or context menu item in the listing view:
|
Refs #583 |
stsewd
reviewed
Oct 8, 2025
readthedocsext/theme/templates/socialaccount/partials/social_account_list.html
Show resolved
Hide resolved
ericholscher
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Oct 12, 2025
Needed for readthedocs/ext-theme#655, which otherwise I need to override the Allauth views for, and this seems useful in other places if we want to keep linking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like this is an obvious place people will look for this,
so we should make it more visible there?