Skip to content

Add Manage GH App dialog in connected accounts #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Manage GH App dialog in connected accounts #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions readthedocsext/theme/templates/socialaccount/partials/social_account_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,16 @@
{% endblock top_left_menu_items %}

{% block create_button %}
<div class="ui green button"
data-bind="click: $root.show_modal('socialaccount-connections')">
{% trans "Add new connection" %}

<div class="two column">
<a href="https://github.com/apps/{{ GITHUB_APP_NAME }}/installations/new/"
target="_blank">
<div class="ui button green">{% trans "Manage GitHub App" %}</div>
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons like this shouldn't be added to this section. The top button on a listing view is strictly for adding an item to the listing.

The standard pattern we're following is this should be an icon button or context menu item in the listing view:

Image

<div class="ui button green"
data-bind="click: $root.show_modal('socialaccount-connections')">
{% trans "Add new connection" %}
</div>
</div>
{% endblock create_button %}

Expand Down